Skip to content

Commit 397e289

Browse files
committed
Add image and treemap visual tests. Also, ensure treemap's stroke reflects the paper's bgcolor
1 parent 91a0826 commit 397e289

File tree

6 files changed

+92
-1
lines changed

6 files changed

+92
-1
lines changed

R/plotly_build.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1033,7 +1033,7 @@ coerce_attr_defaults <- function(trace, layout) {
10331033
if (length(trace[["stroke"]]) && !is.default(trace[["stroke"]])) {
10341034
trace$span <- trace[["span"]] %||% default(I(1))
10351035
}
1036-
if (trace[["type"]] %in% c("sunburst", "pie")) {
1036+
if (trace[["type"]] %in% c("sunburst", "pie", "treemap")) {
10371037
# As of v1.46.1, paper_bgcolor defaults to '#fff' which
10381038
# col2rgb() can't parse, but expands to '#ffffff'
10391039
# https://stackoverflow.com/a/2899224/1583084

tests/figs/image-trace/colormodel.svg

Lines changed: 1 addition & 0 deletions
Loading

tests/figs/treemap/advanced.svg

Lines changed: 1 addition & 0 deletions
Loading

0 commit comments

Comments
 (0)