Skip to content

Fix broken R examples #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cpsievert opened this issue May 19, 2016 · 7 comments
Closed

Fix broken R examples #387

cpsievert opened this issue May 19, 2016 · 7 comments
Assignees
Labels

Comments

@cpsievert
Copy link
Contributor

Some of our r pages are using old, backward-incompatible code -- here are some things to watch out for:

  • Trace properties are no longer inherited when adding traces to an existing plot. So, for example, the second example on https://plot.ly/r/bar-charts/ should be:
p2 <- add_trace(
  p,
  x = c("giraffes", "orangutans", "monkeys"),
  y = c(12, 18, 29),
  name = "LA Zoo",
  type = "bar"
)

instead of

p2 <- add_trace(
  p,
  x = c("giraffes", "orangutans", "monkeys"),
  y = c(12, 18, 29),
  name = "LA Zoo",
  filename="r-docs/simple-bars"
)
  • Also, note that filename is no longer an argument in plot_ly() or add_trace(). It is only relevant for plotly_POST()
@timelyportfolio
Copy link
Contributor

I plan to get to a lot of these soon.

@yankev
Copy link
Contributor

yankev commented May 19, 2016

Ye, I'll edit some of these as well.

@royr2
Copy link
Contributor

royr2 commented May 19, 2016

Let me know and I can help as well

@MySchizoBuddy
Copy link

it would be beneficial if the code is using the single file format of app.R rather than the ui.R/server.R model

@yankev
Copy link
Contributor

yankev commented May 26, 2016

Pushed changes for:

  • Basic Charts
  • Statistical Charts
  • Scientific Charts
  • Maps
  • 3D Charts
  • Events and controls
  • Layout Options Note: Latex example is broken: Issue 375
  • File Settings
  • Shiny Gallery

Edit: Checked all examples in the shiny gallery except for the UN and Finance one because of missing data/dependencies @royr2 could you check these if you get the chance?

@yankev
Copy link
Contributor

yankev commented Jun 7, 2016

I think this can be closed. It's possible that I might've missed something, but in that case a new issue can be made and looked at on a case by case manner.

@yankev yankev closed this as completed Jun 7, 2016
@cldougl
Copy link
Member

cldougl commented Jun 7, 2016

@yankev +1 for closing (this massive issue) but can you open an issue for the shiny example w/ missing depends and link it like you did for the latex ex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants