From 5d7e90ff9af301a7920646af0b0500bd7373a3ae Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Farzat?= <andrefarzat@gmail.com>
Date: Sun, 3 Feb 2019 21:25:27 -0200
Subject: [PATCH 1/3] trying to improve PlotlyViaWindowModule docs

---
 README.md | 29 +++++++++++++++++++++++++++--
 1 file changed, 27 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index 9d1046c..0b3d059 100644
--- a/README.md
+++ b/README.md
@@ -83,6 +83,8 @@ For a full description of Plotly chart types and attributes see the following re
 * [Plotly JavaScript API documentation](https://plot.ly/javascript/)
 * [Full plotly.js attribute listing](https://plot.ly/javascript/reference/)
 
+The `plotly.js` is bundled within the angular code. To avoid this, please read [how to customize the plotlyjs bundle](#customizing-the-plotlyjs-bundle) below.
+
 ## API Reference
 
 ### Basic Props
@@ -172,7 +174,29 @@ export class AppModule { }
 
 ### Plotly Via Window Module
 
-If you want to use a [different precompiled bundle](https://github.com/plotly/plotly.js/blob/master/dist/README.md#partial-bundles) or if you wish to [assemble you own customized bundle](https://github.com/plotly/plotly.js#modules), you can use `PlotlyViaWindowModule` to force the use of `window.Plotly` object. You can add the script via tag `<script>` direct on your code, or add it as a [global script on angular.json](https://github.com/angular/angular-cli/wiki/stories-global-scripts#global-scripts).
+`plotly.js` can be added as a [global script on angular.json](https://github.com/angular/angular-cli/wiki/stories-global-scripts#global-scripts) to avoid it beingb bundled into the final project's code. To make this happen, you must first add `plotly.js` path into `angular.json` file as shown below: 
+
+```json
+// angular.json
+{
+    "projects": {
+        "project-name": {
+            "architect": {
+                "build": {
+                    "options": {
+                        "scripts": [
+                            "node_modules/plotly.js/dist/plotly.min.js" // add this
+                        ]
+                    }
+                }
+            }
+        }
+    }
+}
+```
+
+This will include `plotly.js` into the `vendor.js` file generated by angular CLI build process, and `plotly.js` library will be loaded before angular and your project's code. The `window.Plotly` will be available. Thus, you must use `PlotlyViaWindowModule` module to force `angular-plotly.js` to use `window.Plotly` object:
+
 
 ```typescript
 import { NgModule } from '@angular/core';
@@ -187,6 +211,7 @@ import { PlotlyViaWindowModule } from 'angular-plotly.js';
 export class AppModule { }
 ```
 
+If you want to use a [different precompiled bundle](https://github.com/plotly/plotly.js/blob/master/dist/README.md#partial-bundles) or if you wish to [assemble you own customized bundle](https://github.com/plotly/plotly.js#modules), you can use `PlotlyViaWindowModule` to force the use of `window.Plotly` object as shown above.
 
 ## Development
 
@@ -210,4 +235,4 @@ $ npm run test
 
 ## License
 
-&copy; 2018 Plotly, Inc. MIT License.
+&copy; 2019 Plotly, Inc. MIT License.

From abe9ce9945c633df11071a83d2655802a7d076f7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Farzat?= <andrefarzat@gmail.com>
Date: Sun, 3 Feb 2019 21:27:03 -0200
Subject: [PATCH 2/3] json -> javascript

---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README.md b/README.md
index 0b3d059..73ffb24 100644
--- a/README.md
+++ b/README.md
@@ -176,7 +176,7 @@ export class AppModule { }
 
 `plotly.js` can be added as a [global script on angular.json](https://github.com/angular/angular-cli/wiki/stories-global-scripts#global-scripts) to avoid it beingb bundled into the final project's code. To make this happen, you must first add `plotly.js` path into `angular.json` file as shown below: 
 
-```json
+```javascript
 // angular.json
 {
     "projects": {

From 019ba679cfdc45c0a8cf99a2b5821caef43db248 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Farzat?= <andrefarzat@gmail.com>
Date: Sun, 3 Feb 2019 21:29:00 -0200
Subject: [PATCH 3/3] adding ... to docs

---
 README.md | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/README.md b/README.md
index 73ffb24..720d43a 100644
--- a/README.md
+++ b/README.md
@@ -179,10 +179,13 @@ export class AppModule { }
 ```javascript
 // angular.json
 {
+    ...
     "projects": {
-        "project-name": {
+        "project-name": { // This is your project's name
+            ...
             "architect": {
                 "build": {
+                    ...
                     "options": {
                         "scripts": [
                             "node_modules/plotly.js/dist/plotly.min.js" // add this
@@ -190,6 +193,7 @@ export class AppModule { }
                     }
                 }
             }
+            ...
         }
     }
 }