Fix nonexistent InputBag on Symfony 4.x

Author: ondrejmirtes

composer.json

@@ -15,7 +15,7 @@
   "require": {
     "php": "^7.1 || ^8.0",
     "ext-simplexml": "*",
-    "phpstan/phpstan": "^0.12.97"
+    "phpstan/phpstan": "^0.12.98"
   },
   "conflict": {
     "symfony/framework-bundle": "<3.0"

extension.neon

@@ -25,9 +25,7 @@ parameters:
 		- stubs/Symfony/Component/Form/FormView.stub
 		- stubs/Symfony/Component/HttpFoundation/Cookie.stub
 		- stubs/Symfony/Component/HttpFoundation/HeaderBag.stub
-		- stubs/Symfony/Component/HttpFoundation/InputBag.stub
 		- stubs/Symfony/Component/HttpFoundation/ParameterBag.stub
-		- stubs/Symfony/Component/HttpFoundation/Request.stub
 		- stubs/Symfony/Component/HttpFoundation/Session.stub
 		- stubs/Symfony/Component/Process/Process.stub
 		- stubs/Symfony/Component/PropertyAccess/PropertyPathInterface.stub
@@ -245,3 +243,7 @@ services:
 	-
 		factory: PHPStan\Type\Symfony\ParameterDynamicReturnTypeExtension(Symfony\Bundle\FrameworkBundle\Controller\Controller, 'getParameter', null, %symfony.constant_hassers%)
 		tags: [phpstan.broker.dynamicMethodReturnTypeExtension]
+	-
+		class: PHPStan\Symfony\InputBagStubFilesExtension
+		tags:
+			- phpstan.stubFilesExtension

src/Symfony/InputBagStubFilesExtension.php

@@ -0,0 +1,22 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Symfony;
+
+use PHPStan\PhpDoc\StubFilesExtension;
+
+class InputBagStubFilesExtension implements StubFilesExtension
+{
+
+	public function getFiles(): array
+	{
+		if (!class_exists('Symfony\Component\HttpFoundation\InputBag')) {
+			return [];
+		}
+
+		return [
+			__DIR__ . '/../../stubs/Symfony/Component/HttpFoundation/InputBag.stub',
+			__DIR__ . '/../../stubs/Symfony/Component/HttpFoundation/Request.stub',
+		];
+	}
+
+}

tests/Rules/NonexistentInputBagClassTest.php

@@ -0,0 +1,32 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules;
+
+use PHPStan\Rules\Methods\CallMethodsRule;
+use PHPStan\Testing\RuleTestCase;
+
+/**
+ * @extends RuleTestCase<CallMethodsRule>
+ */
+class NonexistentInputBagClassTest extends RuleTestCase
+{
+
+	protected function getRule(): \PHPStan\Rules\Rule
+	{
+		return self::getContainer()->getByType(CallMethodsRule::class);
+	}
+
+	public function testInputBag(): void
+	{
+		$this->analyse([__DIR__ . '/data/input_bag.php'], []);
+	}
+
+	public static function getAdditionalConfigFiles(): array
+	{
+		return [
+			__DIR__ . '/../../extension.neon',
+			__DIR__ . '/../../rules.neon',
+		];
+	}
+
+}

tests/Rules/data/input_bag.php

@@ -0,0 +1,23 @@
+<?php
+
+namespace InputBagTest;
+
+use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\Routing\Annotation\Route;
+
+class TestController extends AbstractController
+{
+	/**
+	 * @Route("/test", name="test")
+	 */
+	public function index(Request $request): Response
+	{
+		$foo = $request->query->get('foo');
+
+		return $this->render('test/index.html.twig', [
+			'controller_name' => 'TestController',
+		]);
+	}
+}