Change error messages to my taste

Author: ondrejmirtes

src/Rules/Functions/ArrayFilterRule.php

@@ -62,7 +62,7 @@ public function processNode(Node $node, Scope $scope): array
 		$isSuperType = $falsyType->isSuperTypeOf($arrayType->getIterableValueType());
 
 		if ($isSuperType->no()) {
-			$message = 'Parameter #1 $array (%s) to function array_filter cannot contain empty values, call has no effect.';
+			$message = 'Parameter #1 $array (%s) to function array_filter does not contain falsy values, the array will always stay the same.';
 			return [
 				RuleErrorBuilder::message(sprintf(
 					$message,
@@ -72,7 +72,7 @@ public function processNode(Node $node, Scope $scope): array
 		}
 
 		if ($isSuperType->yes()) {
-			$message = 'Parameter #1 $array (%s) to function array_filter can only contain empty values, call always results in [].';
+			$message = 'Parameter #1 $array (%s) to function array_filter contains falsy values only, the result will always be an empty array.';
 			return [
 				RuleErrorBuilder::message(sprintf(
 					$message,

tests/PHPStan/Rules/Functions/ArrayFilterRuleTest.php

@@ -20,43 +20,43 @@ public function testFile(): void
 	{
 		$expectedErrors = [
 			[
-				'Parameter #1 $array (array{1, 3}) to function array_filter cannot contain empty values, call has no effect.',
+				'Parameter #1 $array (array{1, 3}) to function array_filter does not contain falsy values, the array will always stay the same.',
 				11,
 			],
 			[
-				'Parameter #1 $array (array{\'test\'}) to function array_filter cannot contain empty values, call has no effect.',
+				'Parameter #1 $array (array{\'test\'}) to function array_filter does not contain falsy values, the array will always stay the same.',
 				12,
 			],
 			[
-				'Parameter #1 $array (array{true, true}) to function array_filter cannot contain empty values, call has no effect.',
+				'Parameter #1 $array (array{true, true}) to function array_filter does not contain falsy values, the array will always stay the same.',
 				17,
 			],
 			[
-				'Parameter #1 $array (array{stdClass}) to function array_filter cannot contain empty values, call has no effect.',
+				'Parameter #1 $array (array{stdClass}) to function array_filter does not contain falsy values, the array will always stay the same.',
 				18,
 			],
 			[
-				'Parameter #1 $array (array<stdClass>) to function array_filter cannot contain empty values, call has no effect.',
+				'Parameter #1 $array (array<stdClass>) to function array_filter does not contain falsy values, the array will always stay the same.',
 				20,
 			],
 			[
-				'Parameter #1 $array (array{0}) to function array_filter can only contain empty values, call always results in [].',
+				'Parameter #1 $array (array{0}) to function array_filter contains falsy values only, the result will always be an empty array.',
 				23,
 			],
 			[
-				'Parameter #1 $array (array{null}) to function array_filter can only contain empty values, call always results in [].',
+				'Parameter #1 $array (array{null}) to function array_filter contains falsy values only, the result will always be an empty array.',
 				24,
 			],
 			[
-				'Parameter #1 $array (array{null, null}) to function array_filter can only contain empty values, call always results in [].',
+				'Parameter #1 $array (array{null, null}) to function array_filter contains falsy values only, the result will always be an empty array.',
 				25,
 			],
 			[
-				'Parameter #1 $array (array{null, 0}) to function array_filter can only contain empty values, call always results in [].',
+				'Parameter #1 $array (array{null, 0}) to function array_filter contains falsy values only, the result will always be an empty array.',
 				26,
 			],
 			[
-				'Parameter #1 $array (array<false|null>) to function array_filter can only contain empty values, call always results in [].',
+				'Parameter #1 $array (array<false|null>) to function array_filter contains falsy values only, the result will always be an empty array.',
 				27,
 			],
 			[