Only specify types for Variables

This leaves us only the same bugs that were already there.

Author: herndlm

src/Analyser/TypeSpecifier.php

@@ -259,12 +259,6 @@ public function specifyTypesInCondition(
 				);
 			}
 
-			$exprLeftType = $scope->getType($expr->left);
-			$exprRightType = $scope->getType($expr->right);
-			if ($expr->left instanceof Expr\CallLike && $expr->right instanceof Expr\CallLike && !$exprLeftType instanceof ConstantType && !$exprRightType instanceof ConstantType) {
-				return new SpecifiedTypes();
-			}
-
 			if ($context->true()) {
 				$type = TypeCombinator::intersect($scope->getType($expr->right), $scope->getType($expr->left));
 				$leftTypes = $this->create($expr->left, $type, $context, false, $scope);
@@ -281,6 +275,9 @@ public function specifyTypesInCondition(
 					return $leftTypes->unionWith($rightTypes);
 				}
 
+				$exprLeftType = $scope->getType($expr->left);
+				$exprRightType = $scope->getType($expr->right);
+
 				$types = null;
 
 				if (
@@ -321,8 +318,10 @@ public function specifyTypesInCondition(
 					return $types;
 				}
 
-				return $this->create($expr->left, $exprLeftType, $context, false, $scope)->normalize($scope)
-					->intersectWith($this->create($expr->right, $exprRightType, $context, false, $scope)->normalize($scope));
+				if ($expr->left instanceof Expr\Variable && $expr->right instanceof Expr\Variable) {
+					return $this->create($expr->left, $exprLeftType, $context, false, $scope)->normalize($scope)
+						->intersectWith($this->create($expr->right, $exprRightType, $context, false, $scope)->normalize($scope));
+				}
 			}
 
 		} elseif ($expr instanceof Node\Expr\BinaryOp\NotIdentical) {
@@ -357,9 +356,6 @@ public function specifyTypesInCondition(
 
 			$leftType = $scope->getType($expr->left);
 			$rightType = $scope->getType($expr->right);
-			if ($expr->left instanceof Expr\CallLike && $expr->right instanceof Expr\CallLike && !$leftType instanceof ConstantType && !$rightType instanceof ConstantType) {
-				return new SpecifiedTypes();
-			}
 
 			$leftBooleanType = $leftType->toBoolean();
 			if ($leftBooleanType instanceof ConstantBooleanType && $rightType instanceof BooleanType) {