Also make the isNotSame with CallLikes returning constants fail

Author: herndlm

tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeMethodCallRuleTest.php

@@ -84,6 +84,10 @@ public function testRule(): void
 				'Call to method ImpossibleMethodCall\Foo::isSame() with \'foo\' and \'foo\' will always evaluate to true.',
 				101,
 			],
+			[
+				'Call to method ImpossibleMethodCall\Foo::isNotSame() with \'foo\' and \'foo\' will always evaluate to false.',
+				104,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/Comparison/data/impossible-method-call.php

@@ -98,10 +98,10 @@ public function doDolor(\stdClass $std1, \stdClass $std2)
 		if ($this->isNotSame(self::createStdClass('b'), self::createStdClass('b'))) {
 
 		}
-		if ($this->isSame(self::returnFoo(), self::returnFoo())) {
+		if ($this->isSame(self::returnFoo('a'), self::returnFoo('a'))) {
 
 		}
-		if ($this->isNotSame(self::returnFoo(), self::returnFoo())) {
+		if ($this->isNotSame(self::returnFoo('b'), self::returnFoo('b'))) {
 
 		}
 	}
@@ -119,7 +119,7 @@ public static function createStdClass(string $foo): \stdClass
 	/**
 	 * @return 'foo'
 	 */
-	public static function returnFoo(): string
+	public static function returnFoo(string $foo): string
 	{
 		return 'foo';
 	}