Skip to content

Add missing CI for extensions #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
12 tasks done
nikic opened this issue Dec 21, 2020 · 7 comments
Closed
12 tasks done

Add missing CI for extensions #29

nikic opened this issue Dec 21, 2020 · 7 comments
Labels

Comments

@nikic
Copy link
Member

nikic commented Dec 21, 2020

The following extensions currently do not have CI testing or only incomplete testing. These should be tested on Azure Pipelines Linux x64 configuration if possible.

These extensions are fully tested on Windows (AppVeyor). Having additional testing on Linux would be valuable, but is not critical:

@nikic nikic added the testing label Dec 21, 2020
@cmb69
Copy link
Member

cmb69 commented Dec 21, 2020

FWIW, ext/odbc and ext/pdo_odbc are built and tested on AppVeyor against MS SQLServer. Testing against other databases would certainly be highly desireable, but likely many tests would fail (I ran the tests against MySQL, and roughly half of them failed).

@nikic
Copy link
Member Author

nikic commented Dec 21, 2020

@cmb69 Thanks for the information, I was not aware that there are tested on AppVeyor. Having these tested on Linux and other DBs would be good, but it's reassuring that at least we have them somewhere...

@nikic
Copy link
Member Author

nikic commented Dec 21, 2020

I've added builds for PDO ODBC and PDO Firebird. PDO DBlib is also easy to build, but each test waits for a ~10s timeout, so we'd have to actually set up the server side for that to be feasible.

@nikic
Copy link
Member Author

nikic commented Jan 14, 2021

PDO DBLib build & test has been added in php/php-src#6569.

@nikic
Copy link
Member Author

nikic commented Jan 15, 2021

OCI and PDO OCI build has been added in php/php-src#6604.

@nikic nikic mentioned this issue Feb 16, 2021
@kocsismate
Copy link
Member

kocsismate commented Aug 24, 2023

ext/odbc and ext/pdo_odbc tests are enabled on LInux, test coverage is significantly improved: php/php-src#11938

@SakiTakamachi
Copy link
Member

pdo_oci has been decided to be unbundled, and tests for pdo_firebird have been added through the following pull request.

php/php-src#12677

Therefore, this task may be considered complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants