change from review

devnexen · devnexen · commit e765f7cb20d0 · 2025-05-03T16:27:32.000+01:00
diff --git a/ext/date/php_date.c b/ext/date/php_date.c
@@ -5346,7 +5346,7 @@ static void php_do_date_sunrise_sunset(INTERNAL_FUNCTION_PARAMETERS, bool calc_s
 	if (N > 24 || N < 0) {
 		N -= floor(N / 24) * 24;
 	}
-	if (N > 24 || N < 0 || !zend_finite(N)) {
+	if (!(N <= 24 && N > 0)) {
 		RETURN_FALSE;
 	}
 
diff --git a/ext/date/tests/gh18481.phpt b/ext/date/tests/gh18481.phpt
@@ -1,5 +1,5 @@
 --TEST--
-GH-18481 date_sunrise with utcOffset as INF
+GH-18481 (date_sunrise with utcOffset as INF)
 --FILE--
 <?php
 

Original file line number	Diff line number	Diff line change
`@@ -5346,7 +5346,7 @@ static void php_do_date_sunrise_sunset(INTERNAL_FUNCTION_PARAMETERS, bool calc_s`
`5346`	`5346`	`if (N > 24 \|\| N < 0) {`
`5347`	`5347`	`N -= floor(N / 24) * 24;`
`5348`	`5348`	`}`
`5349`		`- if (N > 24 \|\| N < 0 \|\| !zend_finite(N)) {`
	`5349`	`+ if (!(N <= 24 && N > 0)) {`
`5350`	`5350`	`RETURN_FALSE;`
`5351`	`5351`	`}`
`5352`	`5352`
-Original file line number
+Diff line change
@@ @@ -1,5 +1,5 @@ @@
 --TEST--
 -GH-18481 date_sunrise with utcOffset as INF
 +GH-18481 (date_sunrise with utcOffset as INF)
 --FILE--
 <?php