Skip to content

Commit c41ac5d

Browse files
committed
add tests
1 parent abf0e37 commit c41ac5d

File tree

2 files changed

+22
-1
lines changed

2 files changed

+22
-1
lines changed

ext/date/php_date.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5346,7 +5346,7 @@ static void php_do_date_sunrise_sunset(INTERNAL_FUNCTION_PARAMETERS, bool calc_s
53465346
if (N > 24 || N < 0) {
53475347
N -= floor(N / 24) * 24;
53485348
}
5349-
if (N > 24 || N < 0 || !zend_finite(N)) {
5349+
if (!(N <= 24 && N >= 0)) {
53505350
RETURN_FALSE;
53515351
}
53525352

ext/date/tests/gh18481.phpt

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
--TEST--
2+
GH-18481 (date_sunrise with utcOffset as INF)
3+
--FILE--
4+
<?php
5+
6+
foreach ([-NAN, NAN, INF, -INF] as $offset) {
7+
var_dump(date_sunrise(time(), SUNFUNCS_RET_STRING, 38.4, -9, 90, $offset));
8+
}
9+
?>
10+
--EXPECTF--
11+
Deprecated: Function date_sunrise() is deprecated in %s on line %d
12+
bool(false)
13+
14+
Deprecated: Function date_sunrise() is deprecated in %s on line %d
15+
bool(false)
16+
17+
Deprecated: Function date_sunrise() is deprecated in %s on line %d
18+
bool(false)
19+
20+
Deprecated: Function date_sunrise() is deprecated in %s on line %d
21+
bool(false)

0 commit comments

Comments
 (0)