Skip to content

Commit ac05c8f

Browse files
committed
Merge branch 'PHP-8.1' into PHP-8.2
* PHP-8.1: [skip ci] Skip function JIT in nightly for ASAN
2 parents 4f37084 + a2dcb03 commit ac05c8f

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

.github/nightly_matrix.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ function get_matrix_include(array $branches) {
5252
'zts' => true,
5353
'configuration_parameters' => "CFLAGS='-fsanitize=undefined,address -DZEND_TRACK_ARENA_ALLOC' LDFLAGS='-fsanitize=undefined,address'",
5454
'run_tests_parameters' => '--asan',
55-
'timeout_minutes' => 480,
55+
'test_function_jit' => false,
5656
];
5757
if ($branch['ref'] !== 'PHP-8.0') {
5858
$jobs[] = [
@@ -62,6 +62,7 @@ function get_matrix_include(array $branches) {
6262
'zts' => false,
6363
'run_tests_parameters' => '--repeat 2',
6464
'timeout_minutes' => 360,
65+
'test_function_jit' => true,
6566
];
6667
$jobs[] = [
6768
'name' => '_VARIATION',
@@ -70,6 +71,7 @@ function get_matrix_include(array $branches) {
7071
'zts' => true,
7172
'configuration_parameters' => "CFLAGS='-DZEND_RC_DEBUG=1 -DPROFITABILITY_CHECKS=0 -DZEND_VERIFY_FUNC_INFO=1'",
7273
'timeout_minutes' => 360,
74+
'test_function_jit' => true,
7375
];
7476
}
7577
}

.github/workflows/nightly.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,11 @@ jobs:
4141
debug: [true, false]
4242
name: ['']
4343
run_tests_parameters: ['']
44-
timeout_minutes: [360]
44+
test_function_jit: [true]
4545
zts: [true, false]
4646
include: ${{ fromJson(needs.GENERATE_MATRIX.outputs.matrix-include) }}
4747
name: "${{ matrix.branch.name }}_LINUX_X64${{ matrix.name }}_${{ matrix.debug && 'DEBUG' || 'RELEASE' }}_${{ matrix.zts && 'ZTS' || 'NTS' }}"
4848
runs-on: ubuntu-20.04
49-
timeout-minutes: ${{ matrix.timeout_minutes }}
5049
steps:
5150
- name: git checkout
5251
uses: actions/checkout@v3
@@ -95,6 +94,9 @@ jobs:
9594
-d zend_extension=opcache.so
9695
-d opcache.enable_cli=1
9796
- name: Test Function JIT
97+
# ASAN frequently timeouts. Each test run takes ~90 minutes, we can
98+
# avoid running into the 6 hour timeout by skipping the function JIT.
99+
if: matrix.test_function_jit
98100
uses: ./.github/actions/test-linux
99101
with:
100102
testArtifacts: ${{ matrix.branch.name }}_${{ matrix.name }}_${{ matrix.debug && 'DEBUG' || 'RELEASE' }}_${{ matrix.zts && 'ZTS' || 'NTS' }} Function JIT

0 commit comments

Comments
 (0)