Skip to content

Commit a578c27

Browse files
authored
Improve link styling in PHPInfo (#15077)
* Improve link styling in PHPInfo The previous styling with the fixed background color didn't work well in dark mode. Remove the background and make links inherit the regular text color. To make them visually detectable the underlining behavior is reversed. The underline is now shown when not hovering and hidden when hovering. * Preserve the headline linking behavior
1 parent b7e43bd commit a578c27

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

ext/standard/css.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ PHPAPI ZEND_COLD void php_info_print_css(void) /* {{{ */
2121
{
2222
PUTS("body {background-color: #fff; color: #222; font-family: sans-serif;}\n");
2323
PUTS("pre {margin: 0; font-family: monospace;}\n");
24-
PUTS("a:link {color: #009; text-decoration: none; background-color: #fff;}\n");
25-
PUTS("a:hover {text-decoration: underline;}\n");
24+
PUTS("a {color: inherit;}\n");
25+
PUTS("a:hover {text-decoration: none;}\n");
2626
PUTS("table {border-collapse: collapse; border: 0; width: 934px; box-shadow: 1px 2px 3px rgba(0, 0, 0, 0.2);}\n");
2727
PUTS(".center {text-align: center;}\n");
2828
PUTS(".center table {margin: 1em auto; text-align: left;}\n");
@@ -31,7 +31,8 @@ PHPAPI ZEND_COLD void php_info_print_css(void) /* {{{ */
3131
PUTS("th {position: sticky; top: 0; background: inherit;}\n");
3232
PUTS("h1 {font-size: 150%;}\n");
3333
PUTS("h2 {font-size: 125%;}\n");
34-
PUTS("h2 a:link, h2 a:visited{color: inherit; background: inherit;}\n");
34+
PUTS("h2 > a {text-decoration: none;}\n");
35+
PUTS("h2 > a:hover {text-decoration: underline;}\n");
3536
PUTS(".p {text-align: left;}\n");
3637
PUTS(".e {background-color: #ccf; width: 300px; font-weight: bold;}\n");
3738
PUTS(".h {background-color: #99c; font-weight: bold;}\n");

0 commit comments

Comments
 (0)