Running php-cs-fixer

JimTools · JimTools · commit 4164e1e1e5cb · 2025-01-17T21:33:18.000Z
Running php-cs-fixer to fix CS drift
diff --git a/JsonSerializer.php b/JsonSerializer.php
@@ -14,12 +14,8 @@ public function toString(RdKafkaMessage $message): string
             'headers' => $message->getHeaders(),
         ]);
 
-        if (JSON_ERROR_NONE !== json_last_error()) {
-            throw new \InvalidArgumentException(sprintf(
-                'The malformed json given. Error %s and message %s',
-                json_last_error(),
-                json_last_error_msg()
-            ));
+        if (\JSON_ERROR_NONE !== json_last_error()) {
+            throw new \InvalidArgumentException(sprintf('The malformed json given. Error %s and message %s', json_last_error(), json_last_error_msg()));
         }
 
         return $json;
@@ -28,12 +24,8 @@ public function toString(RdKafkaMessage $message): string
     public function toMessage(string $string): RdKafkaMessage
     {
         $data = json_decode($string, true);
-        if (JSON_ERROR_NONE !== json_last_error()) {
-            throw new \InvalidArgumentException(sprintf(
-                'The malformed json given. Error %s and message %s',
-                json_last_error(),
-                json_last_error_msg()
-            ));
+        if (\JSON_ERROR_NONE !== json_last_error()) {
+            throw new \InvalidArgumentException(sprintf('The malformed json given. Error %s and message %s', json_last_error(), json_last_error_msg()));
         }
 
         return new RdKafkaMessage($data['body'], $data['properties'], $data['headers']);
diff --git a/RdKafkaConsumer.php b/RdKafkaConsumer.php
@@ -71,7 +71,7 @@ public function getOffset(): ?int
         return $this->offset;
     }
 
-    public function setOffset(int $offset = null): void
+    public function setOffset(?int $offset = null): void
     {
         if ($this->subscribed) {
             throw new \LogicException('The consumer has already subscribed.');
diff --git a/RdKafkaMessage.php b/RdKafkaMessage.php
@@ -112,7 +112,7 @@ public function setRedelivered(bool $redelivered): void
         $this->redelivered = $redelivered;
     }
 
-    public function setCorrelationId(string $correlationId = null): void
+    public function setCorrelationId(?string $correlationId = null): void
     {
         $this->setHeader('correlation_id', (string) $correlationId);
     }
@@ -122,7 +122,7 @@ public function getCorrelationId(): ?string
         return $this->getHeader('correlation_id');
     }
 
-    public function setMessageId(string $messageId = null): void
+    public function setMessageId(?string $messageId = null): void
     {
         $this->setHeader('message_id', (string) $messageId);
     }
@@ -139,12 +139,12 @@ public function getTimestamp(): ?int
         return null === $value ? null : (int) $value;
     }
 
-    public function setTimestamp(int $timestamp = null): void
+    public function setTimestamp(?int $timestamp = null): void
     {
         $this->setHeader('timestamp', $timestamp);
     }
 
-    public function setReplyTo(string $replyTo = null): void
+    public function setReplyTo(?string $replyTo = null): void
     {
         $this->setHeader('reply_to', $replyTo);
     }
@@ -159,7 +159,7 @@ public function getPartition(): ?int
         return $this->partition;
     }
 
-    public function setPartition(int $partition = null): void
+    public function setPartition(?int $partition = null): void
     {
         $this->partition = $partition;
     }
@@ -169,7 +169,7 @@ public function getKey(): ?string
         return $this->key;
     }
 
-    public function setKey(string $key = null): void
+    public function setKey(?string $key = null): void
     {
         $this->key = $key;
     }
@@ -179,7 +179,7 @@ public function getKafkaMessage(): ?VendorMessage
         return $this->kafkaMessage;
     }
 
-    public function setKafkaMessage(VendorMessage $message = null): void
+    public function setKafkaMessage(?VendorMessage $message = null): void
     {
         $this->kafkaMessage = $message;
     }
diff --git a/RdKafkaProducer.php b/RdKafkaProducer.php
@@ -70,7 +70,7 @@ public function send(Destination $destination, Message $message): void
     /**
      * @return RdKafkaProducer
      */
-    public function setDeliveryDelay(int $deliveryDelay = null): Producer
+    public function setDeliveryDelay(?int $deliveryDelay = null): Producer
     {
         if (null === $deliveryDelay) {
             return $this;
@@ -87,7 +87,7 @@ public function getDeliveryDelay(): ?int
     /**
      * @return RdKafkaProducer
      */
-    public function setPriority(int $priority = null): Producer
+    public function setPriority(?int $priority = null): Producer
     {
         if (null === $priority) {
             return $this;
@@ -101,7 +101,7 @@ public function getPriority(): ?int
         return null;
     }
 
-    public function setTimeToLive(int $timeToLive = null): Producer
+    public function setTimeToLive(?int $timeToLive = null): Producer
     {
         if (null === $timeToLive) {
             return $this;
diff --git a/RdKafkaTopic.php b/RdKafkaTopic.php
@@ -50,7 +50,7 @@ public function getConf(): ?TopicConf
         return $this->conf;
     }
 
-    public function setConf(TopicConf $conf = null): void
+    public function setConf(?TopicConf $conf = null): void
     {
         $this->conf = $conf;
     }
@@ -60,7 +60,7 @@ public function getPartition(): ?int
         return $this->partition;
     }
 
-    public function setPartition(int $partition = null): void
+    public function setPartition(?int $partition = null): void
     {
         $this->partition = $partition;
     }
@@ -70,7 +70,7 @@ public function getKey(): ?string
         return $this->key;
     }
 
-    public function setKey(string $key = null): void
+    public function setKey(?string $key = null): void
     {
         $this->key = $key;
     }
diff --git a/SerializerAwareTrait.php b/SerializerAwareTrait.php
@@ -11,9 +11,6 @@ trait SerializerAwareTrait
      */
     private $serializer;
 
-    /**
-     * @param Serializer $serializer
-     */
     public function setSerializer(Serializer $serializer)
     {
         $this->serializer = $serializer;
diff --git a/Tests/RdKafkaConnectionFactoryConfigTest.php b/Tests/RdKafkaConnectionFactoryConfigTest.php
@@ -33,9 +33,6 @@ public function testThrowIfSchemeIsNotSupported()
 
     /**
      * @dataProvider provideConfigs
-     *
-     * @param mixed $config
-     * @param mixed $expectedConfig
      */
     public function testShouldParseConfigurationAsExpected($config, $expectedConfig)
     {
diff --git a/Tests/RdKafkaConnectionFactoryTest.php b/Tests/RdKafkaConnectionFactoryTest.php
@@ -70,9 +70,6 @@ public function testShouldBeExpectedDefaultDsnConfig()
 
     /**
      * @dataProvider provideConfigs
-     *
-     * @param mixed $config
-     * @param mixed $expectedConfig
      */
     public function testShouldParseConfigurationAsExpected($config, $expectedConfig)
     {
diff --git a/Tests/Spec/RdKafkaMessageTest.php b/Tests/Spec/RdKafkaMessageTest.php
@@ -7,9 +7,6 @@
 
 class RdKafkaMessageTest extends MessageSpec
 {
-    /**
-     * {@inheritdoc}
-     */
     protected function createMessage()
     {
         return new RdKafkaMessage();
diff --git a/Tests/Spec/RdKafkaTopicTest.php b/Tests/Spec/RdKafkaTopicTest.php
@@ -7,9 +7,6 @@
 
 class RdKafkaTopicTest extends TopicSpec
 {
-    /**
-     * {@inheritdoc}
-     */
     protected function createTopic()
     {
         return new RdKafkaTopic(self::EXPECTED_TOPIC_NAME);
diff --git a/Tests/bootstrap.php b/Tests/bootstrap.php
@@ -8,7 +8,7 @@
 if (false == file_exists($kafkaStubsDir)) {
     $kafkaStubsDir = __DIR__.'/../../../vendor/kwn/php-rdkafka-stubs';
     if (false == file_exists($kafkaStubsDir)) {
-        throw new \LogicException('The kafka extension is not loaded and stubs could not be found as well');
+        throw new LogicException('The kafka extension is not loaded and stubs could not be found as well');
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ public function getOffset(): ?int`
`71`	`71`	`return $this->offset;`
`72`	`72`	`}`
`73`	`73`
`74`		`- public function setOffset(int $offset = null): void`
	`74`	`+ public function setOffset(?int $offset = null): void`
`75`	`75`	`{`
`76`	`76`	`if ($this->subscribed) {`
`77`	`77`	`throw new \LogicException('The consumer has already subscribed.');`
Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ public function setRedelivered(bool $redelivered): void`
`112`	`112`	`$this->redelivered = $redelivered;`
`113`	`113`	`}`
`114`	`114`
`115`		`- public function setCorrelationId(string $correlationId = null): void`
	`115`	`+ public function setCorrelationId(?string $correlationId = null): void`
`116`	`116`	`{`
`117`	`117`	`$this->setHeader('correlation_id', (string) $correlationId);`
`118`	`118`	`}`
`@@ -122,7 +122,7 @@ public function getCorrelationId(): ?string`
`122`	`122`	`return $this->getHeader('correlation_id');`
`123`	`123`	`}`
`124`	`124`
`125`		`- public function setMessageId(string $messageId = null): void`
	`125`	`+ public function setMessageId(?string $messageId = null): void`
`126`	`126`	`{`
`127`	`127`	`$this->setHeader('message_id', (string) $messageId);`
`128`	`128`	`}`
`@@ -139,12 +139,12 @@ public function getTimestamp(): ?int`
`139`	`139`	`return null === $value ? null : (int) $value;`
`140`	`140`	`}`
`141`	`141`
`142`		`- public function setTimestamp(int $timestamp = null): void`
	`142`	`+ public function setTimestamp(?int $timestamp = null): void`
`143`	`143`	`{`
`144`	`144`	`$this->setHeader('timestamp', $timestamp);`
`145`	`145`	`}`
`146`	`146`
`147`		`- public function setReplyTo(string $replyTo = null): void`
	`147`	`+ public function setReplyTo(?string $replyTo = null): void`
`148`	`148`	`{`
`149`	`149`	`$this->setHeader('reply_to', $replyTo);`
`150`	`150`	`}`
`@@ -159,7 +159,7 @@ public function getPartition(): ?int`
`159`	`159`	`return $this->partition;`
`160`	`160`	`}`
`161`	`161`
`162`		`- public function setPartition(int $partition = null): void`
	`162`	`+ public function setPartition(?int $partition = null): void`
`163`	`163`	`{`
`164`	`164`	`$this->partition = $partition;`
`165`	`165`	`}`
`@@ -169,7 +169,7 @@ public function getKey(): ?string`
`169`	`169`	`return $this->key;`
`170`	`170`	`}`
`171`	`171`
`172`		`- public function setKey(string $key = null): void`
	`172`	`+ public function setKey(?string $key = null): void`
`173`	`173`	`{`
`174`	`174`	`$this->key = $key;`
`175`	`175`	`}`
`@@ -179,7 +179,7 @@ public function getKafkaMessage(): ?VendorMessage`
`179`	`179`	`return $this->kafkaMessage;`
`180`	`180`	`}`
`181`	`181`
`182`		`- public function setKafkaMessage(VendorMessage $message = null): void`
	`182`	`+ public function setKafkaMessage(?VendorMessage $message = null): void`
`183`	`183`	`{`
`184`	`184`	`$this->kafkaMessage = $message;`
`185`	`185`	`}`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ public function send(Destination $destination, Message $message): void`
`70`	`70`	`/**`
`71`	`71`	`* @return RdKafkaProducer`
`72`	`72`	`*/`
`73`		`- public function setDeliveryDelay(int $deliveryDelay = null): Producer`
	`73`	`+ public function setDeliveryDelay(?int $deliveryDelay = null): Producer`
`74`	`74`	`{`
`75`	`75`	`if (null === $deliveryDelay) {`
`76`	`76`	`return $this;`
`@@ -87,7 +87,7 @@ public function getDeliveryDelay(): ?int`
`87`	`87`	`/**`
`88`	`88`	`* @return RdKafkaProducer`
`89`	`89`	`*/`
`90`		`- public function setPriority(int $priority = null): Producer`
	`90`	`+ public function setPriority(?int $priority = null): Producer`
`91`	`91`	`{`
`92`	`92`	`if (null === $priority) {`
`93`	`93`	`return $this;`
`@@ -101,7 +101,7 @@ public function getPriority(): ?int`
`101`	`101`	`return null;`
`102`	`102`	`}`
`103`	`103`
`104`		`- public function setTimeToLive(int $timeToLive = null): Producer`
	`104`	`+ public function setTimeToLive(?int $timeToLive = null): Producer`
`105`	`105`	`{`
`106`	`106`	`if (null === $timeToLive) {`
`107`	`107`	`return $this;`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ public function getConf(): ?TopicConf`
`50`	`50`	`return $this->conf;`
`51`	`51`	`}`
`52`	`52`
`53`		`- public function setConf(TopicConf $conf = null): void`
	`53`	`+ public function setConf(?TopicConf $conf = null): void`
`54`	`54`	`{`
`55`	`55`	`$this->conf = $conf;`
`56`	`56`	`}`
`@@ -60,7 +60,7 @@ public function getPartition(): ?int`
`60`	`60`	`return $this->partition;`
`61`	`61`	`}`
`62`	`62`
`63`		`- public function setPartition(int $partition = null): void`
	`63`	`+ public function setPartition(?int $partition = null): void`
`64`	`64`	`{`
`65`	`65`	`$this->partition = $partition;`
`66`	`66`	`}`
`@@ -70,7 +70,7 @@ public function getKey(): ?string`
`70`	`70`	`return $this->key;`
`71`	`71`	`}`
`72`	`72`
`73`		`- public function setKey(string $key = null): void`
	`73`	`+ public function setKey(?string $key = null): void`
`74`	`74`	`{`
`75`	`75`	`$this->key = $key;`
`76`	`76`	`}`
Original file line number	Diff line number	Diff line change
`@@ -11,9 +11,6 @@ trait SerializerAwareTrait`
`11`	`11`	`*/`
`12`	`12`	`private $serializer;`
`13`	`13`
`14`		`- /**`
`15`		`- * @param Serializer $serializer`
`16`		`- */`
`17`	`14`	`public function setSerializer(Serializer $serializer)`
`18`	`15`	`{`
`19`	`16`	`$this->serializer = $serializer;`
Original file line number	Diff line number	Diff line change
`@@ -33,9 +33,6 @@ public function testThrowIfSchemeIsNotSupported()`
`33`	`33`
`34`	`34`	`/**`
`35`	`35`	`* @dataProvider provideConfigs`
`36`		`- *`
`37`		`- * @param mixed $config`
`38`		`- * @param mixed $expectedConfig`
`39`	`36`	`*/`
`40`	`37`	`public function testShouldParseConfigurationAsExpected($config, $expectedConfig)`
`41`	`38`	`{`
Original file line number	Diff line number	Diff line change
`@@ -70,9 +70,6 @@ public function testShouldBeExpectedDefaultDsnConfig()`
`70`	`70`
`71`	`71`	`/**`
`72`	`72`	`* @dataProvider provideConfigs`
`73`		`- *`
`74`		`- * @param mixed $config`
`75`		`- * @param mixed $expectedConfig`
`76`	`73`	`*/`
`77`	`74`	`public function testShouldParseConfigurationAsExpected($config, $expectedConfig)`
`78`	`75`	`{`
Original file line number	Diff line number	Diff line change
`@@ -7,9 +7,6 @@`
`7`	`7`
`8`	`8`	`class RdKafkaMessageTest extends MessageSpec`
`9`	`9`	`{`
`10`		`- /**`
`11`		`- * {@inheritdoc}`
`12`		`- */`
`13`	`10`	`protected function createMessage()`
`14`	`11`	`{`
`15`	`12`	`return new RdKafkaMessage();`
Original file line number	Diff line number	Diff line change
`@@ -7,9 +7,6 @@`
`7`	`7`
`8`	`8`	`class RdKafkaTopicTest extends TopicSpec`
`9`	`9`	`{`
`10`		`- /**`
`11`		`- * {@inheritdoc}`
`12`		`- */`
`13`	`10`	`protected function createTopic()`
`14`	`11`	`{`
`15`	`12`	`return new RdKafkaTopic(self::EXPECTED_TOPIC_NAME);`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`if (false == file_exists($kafkaStubsDir)) {`
`9`	`9`	`$kafkaStubsDir = __DIR__.'/../../../vendor/kwn/php-rdkafka-stubs';`
`10`	`10`	`if (false == file_exists($kafkaStubsDir)) {`
`11`		`- throw new \LogicException('The kafka extension is not loaded and stubs could not be found as well');`
	`11`	`+ throw new LogicException('The kafka extension is not loaded and stubs could not be found as well');`
`12`	`12`	`}`
`13`	`13`	`}`
`14`	`14`