-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC/PY3: np.unique errors on pd.Series with mixed string/float in python3 #6229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
this is a numpy bug in py3 when trying to order mixed (strings and numbers) There is a solution which I used for pandas (and which numpy will do something similar at some point) so this example is just showing that factorize replaces np.uniques but with a better ordering I think maybe just change this to a code block for the numpy part. (but leave the factorize their) reminds me to add a test for this explicitly ( it is indirectly tested in #6212) as no way to fix |
Ok, thanks for the info.
Do you mean to split it into two code blocks? As a side note and since it would help me with the py2/3 docs compat: Do you know of a good way to handle this during the doc building so we can close this? I am thinking along the lines of conditional parts in |
u could put those 2 lines in a code block is fine I think u can so conditionals with compat.PY3 in a suppressed I python block |
Ok, will try. |
Not yet. I figured waiting for numpy/numpy#641 would be better. What do you think? |
nope go ahead and just change it (if u really want to u can put in a note that numpy will throw an error - and point to the bug -might be useful |
Added note, see latest commit in #6230. |
"Fixed" (comment on doc example failure) in #6230. |
In a similar fashion as #6212, the following fails on Python 3 (
doc/source/reshaping.rst
):Although this error manifests in
numpy
code, I assume this has to do withpd.Series
?The text was updated successfully, but these errors were encountered: