Skip to content

REF: rename DateOffset -> RelativeDeltaOffset #48262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jbrockmendel opened this issue Aug 25, 2022 · 1 comment
Open

REF: rename DateOffset -> RelativeDeltaOffset #48262

jbrockmendel opened this issue Aug 25, 2022 · 1 comment
Labels
Deprecate Functionality to remove in pandas Frequency DateOffsets Needs Discussion Requires discussion from core team before further action

Comments

@jbrockmendel
Copy link
Member

jbrockmendel commented Aug 25, 2022 •
edited
Loading

It used to be that DateOffset was the base class and all other offsets subclassed it. Now BaseOffset is the base class that everything subclasses, RelativeDeltaOffset holds the old-DateOffset logic, and DateOffset is a thin wrapper around RelativeDeltaOffset to make old isinstance(obj, DateOffset) checks work.

It'd be nice if we could expose RelativeDeltaOffset without wrapping it as DateOffset.
@jbrockmendel jbrockmendel added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Aug 25, 2022
@mroeschke
Copy link
Member

DateOffset is in the public API so I guess it would need to be deprecated if RelativeDeltaOffset were to fully replace it.

@mroeschke mroeschke added Frequency DateOffsets Deprecate Functionality to remove in pandas Needs Discussion Requires discussion from core team before further action and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Aug 26, 2022
@DeaMariaLeon DeaMariaLeon mentioned this issue Apr 6, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Frequency DateOffsets Needs Discussion Requires discussion from core team before further action
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbrockmendel @mroeschke