Skip to content

BUG: CI cannot create benchmark environments with Cython < 0.29.24 #44067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
attack68 opened this issue Oct 17, 2021 · 1 comment · Fixed by #44359
Closed
3 tasks done

BUG: CI cannot create benchmark environments with Cython < 0.29.24 #44067

attack68 opened this issue Oct 17, 2021 · 1 comment · Fixed by #44359
Labels
Benchmark Performance (ASV) benchmarks Dependencies Required and optional dependencies
Milestone
1.4

Comments

@attack68
Copy link
Contributor

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pandas.

  • I have confirmed this bug exists on the master branch of pandas.

Reproducible Example

asv continuous -f 1.1 -E virtualenv upstream/master HEAD -b style.Render

RuntimeError: Cannot cythonize with old Cython version (0.29.21 installed, needs 0.29.24)

Issue Description

Needed to update asv.conf.json to get this to work.

Expected Behavior

probably need to update dependency verisons.

Installed Versions

master at 17 Oct.
@attack68 attack68 added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Oct 17, 2021
@alexhlim alexhlim mentioned this issue Oct 17, 2021
Closed
1 task
@simonjayhawkins simonjayhawkins added Benchmark Performance (ASV) benchmarks and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Oct 17, 2021
@simonjayhawkins simonjayhawkins added this to the 1.4 milestone Oct 17, 2021
@simonjayhawkins
Copy link
Member

benchmarks for previous versions are run from master so fix does not need backport.

@simonjayhawkins simonjayhawkins added Dependencies Required and optional dependencies and removed Bug labels Oct 17, 2021
@phofl phofl mentioned this issue Nov 8, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Benchmark Performance (ASV) benchmarks Dependencies Required and optional dependencies
Projects
None yet
Milestone
1.4
Development

Successfully merging a pull request may close this issue.

Update cython version for asv conf phofl/pandas
2 participants
@simonjayhawkins @attack68