Skip to content

DatetimeIndex._use_cached_range, _cached_range not reachable #23080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbrockmendel opened this issue Oct 11, 2018 · 1 comment · Fixed by #23118
Closed

DatetimeIndex._use_cached_range, _cached_range not reachable #23080

jbrockmendel opened this issue Oct 11, 2018 · 1 comment · Fixed by #23118
Labels
Clean Datetime Datetime data dtype
Milestone
0.24.0

Comments

@jbrockmendel
Copy link
Member

Because freq._should_cache() is always False.

My inclination would be to get rid of use_cached_range and cached_range (as opposed to enabling it)
@mroeschke
Copy link
Member

mroeschke commented Oct 11, 2018 •
edited
Loading

I am partial to removing it as well (and possibly some related cruft in tseries/offsets.py). But there's also an issue about re-enabling caching: #17914

@jbrockmendel jbrockmendel mentioned this issue Oct 13, 2018
Merged
4 tasks
@jreback jreback added Datetime Datetime data dtype Clean labels Oct 14, 2018
@jreback jreback added this to the 0.24.0 milestone Oct 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Clean Datetime Datetime data dtype
Projects
None yet
Milestone
0.24.0
Development

Successfully merging a pull request may close this issue.

Remove offset/DTI caching (disabled since 0.14 jbrockmendel/pandas
3 participants
@jreback @jbrockmendel @mroeschke