Valgrind issues found in libmodsecurity #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

LinuxJedi opened this issue Feb 12, 2016 · 2 comments

Assignees

Labels

RIP - libmodsecurity

Milestone

v3.0.0 - OWASP CR...

Contributor

LinuxJedi commented Feb 12, 2016

Found using the unit tests wrapped in valgrind.

src/utils/msc_tree.cc:122 uses malloc, src/utils/ip_tree.cc:47 uses delete
src/utils/msc_tree.cc:116 uses malloc, src/utils/ip_tree.cc:54 uses delete
src/utils/msc_tree.cc:76 uses malloc, src/utils/ip_tree.cc:51 uses delete
src/utils/msc_tree.cc:219 uses malloc, src/utils/ip_tree.cc:42 uses delete
src/utils/msc_tree.cc:763 off by one read (should probably be bytes-1)
src/utils/acmp.cc:358 calloc isn't freed
src/utils/acmp.cc:497 calloc isn't freed
src/operators/rx.h:40 new isn't freed
src/operators/verify_cc.cc:78 needs to use pcre_free when done

zimmerle self-assigned this

zimmerle added this to the v3.0.0 milestone

zimmerle added the RIP - libmodsecurity label

zimmerle modified the milestones: v3.0.0 owasp compatible, v3.0.0 feature complete

zimmerle mentioned this issue

Memory leak owasp-modsecurity/ModSecurity-nginx#7

Closed

Contributor

zimmerle commented Jun 16, 2016

Full output of `make check-valgrind-memcheck', include the listed issues and a few more. They are listed at:

https://gist.github.com/zimmerle/9733074f945a463246e454359108b706

Contributor

zimmerle commented Jun 16, 2016

As of: 21777ae all the issues were closed.

zimmerle closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment