Skip to content

Commit 32627ff

Browse files
committed
Address cppcheck warnings: uselessOverride (The function '...' overrides a function in a base class but is identical to the overridden function)
1 parent a64e820 commit 32627ff

12 files changed

+0
-36
lines changed

src/actions/expire_var.cc

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,6 @@ namespace modsecurity {
3232
namespace actions {
3333

3434

35-
bool ExpireVar::init(std::string *error) {
36-
return true;
37-
}
38-
39-
4035
bool ExpireVar::evaluate(RuleWithActions *rule, Transaction *t) {
4136

4237
std::string expireExpressionExpanded(m_string->evaluate(t));

src/actions/expire_var.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ class ExpireVar : public Action {
4040
m_string(std::move(z)) { }
4141

4242
bool evaluate(RuleWithActions *rule, Transaction *transaction) override;
43-
bool init(std::string *error) override;
4443

4544
private:
4645

src/actions/set_env.cc

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,6 @@ namespace modsecurity {
2626
namespace actions {
2727

2828

29-
bool SetENV::init(std::string *error) {
30-
return true;
31-
}
32-
33-
3429
bool SetENV::evaluate(RuleWithActions *rule, Transaction *t) {
3530
std::string colNameExpanded(m_string->evaluate(t));
3631

src/actions/set_env.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ class SetENV : public Action {
4040
m_string(std::move(z)) { }
4141

4242
bool evaluate(RuleWithActions *rule, Transaction *transaction) override;
43-
bool init(std::string *error) override;
4443

4544
private:
4645
std::unique_ptr<RunTimeString> m_string;

src/actions/set_rsc.cc

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,6 @@ namespace modsecurity {
2626
namespace actions {
2727

2828

29-
bool SetRSC::init(std::string *error) {
30-
return true;
31-
}
32-
33-
3429
bool SetRSC::evaluate(RuleWithActions *rule, Transaction *t) {
3530
std::string colNameExpanded(m_string->evaluate(t));
3631
ms_dbg_a(t, 8, "RESOURCE initiated with value: \'"

src/actions/set_rsc.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ class SetRSC : public Action {
4040
m_string(std::move(z)) { }
4141

4242
bool evaluate(RuleWithActions *rule, Transaction *transaction) override;
43-
bool init(std::string *error) override;
4443

4544
private:
4645
std::unique_ptr<RunTimeString> m_string;

src/actions/set_sid.cc

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,6 @@ namespace modsecurity {
2626
namespace actions {
2727

2828

29-
bool SetSID::init(std::string *error) {
30-
return true;
31-
}
32-
33-
3429
bool SetSID::evaluate(RuleWithActions *rule, Transaction *t) {
3530
std::string colNameExpanded(m_string->evaluate(t));
3631
ms_dbg_a(t, 8, "Session ID initiated with value: \'"

src/actions/set_sid.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ class SetSID : public Action {
4040
m_string(std::move(z)) { }
4141

4242
bool evaluate(RuleWithActions *rule, Transaction *transaction) override;
43-
bool init(std::string *error) override;
4443

4544
private:
4645
std::unique_ptr<RunTimeString> m_string;

src/actions/set_uid.cc

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,6 @@ namespace modsecurity {
2626
namespace actions {
2727

2828

29-
bool SetUID::init(std::string *error) {
30-
return true;
31-
}
32-
33-
3429
bool SetUID::evaluate(RuleWithActions *rule, Transaction *t) {
3530
std::string colNameExpanded(m_string->evaluate(t));
3631
ms_dbg_a(t, 8, "User collection initiated with value: \'"

src/actions/set_uid.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ class SetUID : public Action {
4040
m_string(std::move(z)) { }
4141

4242
bool evaluate(RuleWithActions *rule, Transaction *transaction) override;
43-
bool init(std::string *error) override;
4443

4544
private:
4645
std::unique_ptr<RunTimeString> m_string;

src/actions/set_var.cc

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,6 @@ namespace modsecurity {
3535
namespace actions {
3636

3737

38-
bool SetVar::init(std::string *error) {
39-
return true;
40-
}
41-
42-
4338
bool SetVar::evaluate(RuleWithActions *rule, Transaction *t) {
4439
std::string targetValue;
4540
std::string resolvedPre;

src/actions/set_var.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ class SetVar : public Action {
5959
m_variable(std::move(variable)) { }
6060

6161
bool evaluate(RuleWithActions *rule, Transaction *transaction) override;
62-
bool init(std::string *error) override;
6362

6463
private:
6564
SetVarOperation m_operation;

0 commit comments

Comments
 (0)