Removed unnecessary cppcheck suppression and r-value reference as copy should be avoidded by RVO

Author: eduar-hte

src/modsecurity.cc

@@ -202,7 +202,7 @@ void ModSecurity::serverLog(void *data, std::shared_ptr<RuleMessage> rm) {
     }
 
     if (m_logProperties & TextLogProperty) {
-        std::string &&d = rm->log();
+        auto d = rm->log();
         const void *a = static_cast<const void *>(d.c_str());
         m_logCb(data, a);
         return;

test/cppcheck_suppressions.txt

@@ -43,12 +43,10 @@ functionStatic:src/engine/lua.h:71
 functionConst:src/utils/geo_lookup.h:49
 useInitializationList:src/operators/rbl.h:73
 constStatement:test/common/modsecurity_test.cc:82
-danglingTemporaryLifetime:src/modsecurity.cc:206
 functionStatic:src/operators/geo_lookup.h:35
 duplicateBreak:src/operators/validate_utf8_encoding.cc
 syntaxError:src/transaction.cc:65
 noConstructor:src/variables/variable.h:152
-danglingTempReference:src/modsecurity.cc:206
 knownConditionTrueFalse:src/operators/validate_url_encoding.cc:77
 knownConditionTrueFalse:src/operators/verify_svnr.cc:87
 rethrowNoCurrentException:headers/modsecurity/transaction.h:313