Skip to content

[collector/management] Update Collector Management OpAMP references #6796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

johannaojeling
Copy link
Contributor

Updates the OpAMP references on the Collector Management page to reflect more recent progress. Fixes #6795.

@johannaojeling johannaojeling requested a review from a team as a code owner May 1, 2025 11:13
@opentelemetrybot opentelemetrybot requested review from a team and TylerHelmuth and removed request for a team May 1, 2025 11:14
@@ -291,25 +291,34 @@ $ cat ./storage/agent.log

## Other information

- Blog post [Using OpenTelemetry OpAMP to modify service telemetry on the
go][blog-opamp-service-telemetry]
- Blog posts:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put these resources in reverse chronological order

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

LGTM, if @open-telemetry/collector-approvers are happy too -- see inline question for you.

Comment on lines +309 to +310
[Open Agent Management Protocol]: https://github.com/open-telemetry/opamp-spec
[OpAMP specification]: /docs/specs/opamp/
Copy link
Contributor

@chalin chalin May 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Thanks for linking to the intra-site spec instance.

Comment on lines 306 to 312
https://docs.google.com/document/d/1KtH5atZQUs9Achbce6LiOaJxLbksNJenvgvyKLsJrkc/edit#heading=h.ioikt02qpy5f
https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/cmd/opampsupervisor/specification#collectors-opamp-extension
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@open-telemetry/collector-approvers - is this change in URL ok with you?

Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @open-telemetry/collector-approvers, PTAL.

@svrnm
Copy link
Member

svrnm commented May 9, 2025

@open-telemetry/opamp-spec-approvers @open-telemetry/opamp-go-approvers @open-telemetry/opamp-java-approvers not sure who's best to take a look and approve, so tagging you all, PTAL

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tigran's suggestion for the link looks like the right place to send users. The rest of updates looks great!

@opentelemetrybot opentelemetrybot requested a review from a team May 10, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[collector/management] Update OpAMP references
7 participants