-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[collector/management] Update Collector Management OpAMP references #6796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[collector/management] Update Collector Management OpAMP references #6796
Conversation
@@ -291,25 +291,34 @@ $ cat ./storage/agent.log | |||
|
|||
## Other information | |||
|
|||
- Blog post [Using OpenTelemetry OpAMP to modify service telemetry on the | |||
go][blog-opamp-service-telemetry] | |||
- Blog posts: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put these resources in reverse chronological order
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
LGTM, if @open-telemetry/collector-approvers are happy too -- see inline question for you.
[Open Agent Management Protocol]: https://github.com/open-telemetry/opamp-spec | ||
[OpAMP specification]: /docs/specs/opamp/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 Thanks for linking to the intra-site spec instance.
https://docs.google.com/document/d/1KtH5atZQUs9Achbce6LiOaJxLbksNJenvgvyKLsJrkc/edit#heading=h.ioikt02qpy5f | ||
https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/cmd/opampsupervisor/specification#collectors-opamp-extension |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@open-telemetry/collector-approvers - is this change in URL ok with you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @open-telemetry/collector-approvers, PTAL.
@open-telemetry/opamp-spec-approvers @open-telemetry/opamp-go-approvers @open-telemetry/opamp-java-approvers not sure who's best to take a look and approve, so tagging you all, PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tigran's suggestion for the link looks like the right place to send users. The rest of updates looks great!
Co-authored-by: Tigran Najaryan <[email protected]>
Updates the OpAMP references on the Collector Management page to reflect more recent progress. Fixes #6795.