update comment

ebracho · ebracho · commit 8acfdceba967 · 2024-07-01T17:06:45.000-07:00
diff --git a/instrumentation/opentelemetry-instrumentation-django/src/opentelemetry/instrumentation/django/middleware/otel_middleware.py b/instrumentation/opentelemetry-instrumentation-django/src/opentelemetry/instrumentation/django/middleware/otel_middleware.py
@@ -292,7 +292,8 @@ def process_request(self, request):
                     span, request
                 )
             except Exception:  # pylint: disable=broad-exception-caught
-                # process_response() will not be called, so we need to clean up
+                # Raising an exception here would leak the request span since process_response
+                # would not be called. Log the exception instead.
                 _logger.exception("Exception raised by request_hook")
 
     # pylint: disable=unused-argument

Original file line number	Diff line number	Diff line change
`@@ -292,7 +292,8 @@ def process_request(self, request):`
`292`	`292`	`span, request`
`293`	`293`	`)`
`294`	`294`	`except Exception: # pylint: disable=broad-exception-caught`
`295`		`- # process_response() will not be called, so we need to clean up`
	`295`	`+ # Raising an exception here would leak the request span since process_response`
	`296`	`+ # would not be called. Log the exception instead.`
`296`	`297`	`_logger.exception("Exception raised by request_hook")`
`297`	`298`
`298`	`299`	`# pylint: disable=unused-argument`