Skip to content

Commit e46bd39

Browse files
SBejgatrentm
andauthored
refactor(opentelemetry-sdk-node): use new get*FromEnv() function in NodeSDK's metrics setup (#5578)
Co-authored-by: Trent Mick <[email protected]>
1 parent 141c054 commit e46bd39

File tree

1 file changed

+3
-5
lines changed
  • experimental/packages/opentelemetry-sdk-node/src

1 file changed

+3
-5
lines changed

experimental/packages/opentelemetry-sdk-node/src/sdk.ts

+3-5
Original file line numberDiff line numberDiff line change
@@ -72,13 +72,12 @@ import { NodeSDKConfiguration } from './types';
7272
import {
7373
getBooleanFromEnv,
7474
getStringFromEnv,
75-
diagLogLevelFromString,
7675
getStringListFromEnv,
76+
diagLogLevelFromString,
7777
} from '@opentelemetry/core';
7878
import {
7979
getResourceDetectorsFromEnv,
8080
getSpanProcessorsFromEnv,
81-
filterBlanksAndNulls,
8281
getPropagatorFromEnv,
8382
} from './utils';
8483

@@ -115,11 +114,10 @@ function getValueInMillis(envName: string, defaultValue: number): number {
115114
*/
116115
function configureMetricProviderFromEnv(): IMetricReader[] {
117116
const metricReaders: IMetricReader[] = [];
118-
const metricsExporterList = process.env.OTEL_METRICS_EXPORTER?.trim();
119-
if (!metricsExporterList) {
117+
const enabledExporters = getStringListFromEnv('OTEL_METRICS_EXPORTER');
118+
if (!enabledExporters) {
120119
return metricReaders;
121120
}
122-
const enabledExporters = filterBlanksAndNulls(metricsExporterList.split(','));
123121

124122
if (enabledExporters.length === 0) {
125123
diag.debug('OTEL_METRICS_EXPORTER is empty. Using default otlp exporter.');

0 commit comments

Comments
 (0)