Mark telemetry.disableAddressFieldForInternalTelemetry as beta, usage of deprecated address are ignored #12756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
added
the
release:blocker
… of deprecated address are ignored Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
disableAddressFieldForInternalTelemetry
branch
from
eba3a07 to
3903fe5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12756 +/- ##
=======================================
Coverage 91.45% 91.45%
=======================================
Files 483 483
Lines 26608 26608
=======================================
Hits 24335 24335
Misses 1791 1791
Partials 482 482 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
songy23
reviewed
Mar 28, 2025
There was a problem hiding this comment.
It seems the opentelemetry-operator isn't ready for this change open-telemetry/opentelemetry-operator#3744
|
@songy23 they had enough time. I think we should treat them as any other customer :) Also they can disable the featuregate if not ready. |
songy23
approved these changes
Mar 28, 2025
dmitryax
approved these changes
Mar 29, 2025
Merged
via the queue into
open-telemetry:main
with commit Mar 31, 2025
9912293
60 of 63 checks passed
songy23
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Apr 1, 2025
#### Description open-telemetry/opentelemetry-collector#12756 deprecates telemetry::metrics::address so need to adopt the new configs in test yamls. #### Link to tracking issue #39064
dmathieu
pushed a commit
to dmathieu/opentelemetry-collector-contrib
that referenced
this pull request
Apr 8, 2025
#### Description open-telemetry/opentelemetry-collector#12756 deprecates telemetry::metrics::address so need to adopt the new configs in test yamls. #### Link to tracking issue open-telemetry#39064
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
#### Description open-telemetry/opentelemetry-collector#12756 deprecates telemetry::metrics::address so need to adopt the new configs in test yamls. #### Link to tracking issue open-telemetry#39064
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.