Skip to content

Deprecate blocking in favor of block_on_overflow #12710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Mar 23, 2025

Depends on #12706

@bogdandrutu bogdandrutu requested review from a team, mx-psi, dmathieu and dmitryax as code owners March 23, 2025 23:59
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.50%. Comparing base (7c2c26d) to head (8cfd032).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
exporter/exporterhelper/internal/queue_sender.go 60.00% 4 Missing and 2 partials ⚠️

❌ Your patch status has failed because the patch coverage (60.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12710      +/-   ##
==========================================
- Coverage   91.52%   91.50%   -0.02%     
==========================================
  Files         480      480              
  Lines       26452    26464      +12     
==========================================
+ Hits        24211    24217       +6     
- Misses       1774     1778       +4     
- Partials      467      469       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bogdandrutu bogdandrutu force-pushed the deprecate-blocking branch 6 times, most recently from 12ca6a0 to 3547d76 Compare March 24, 2025 23:26
@bogdandrutu bogdandrutu added this pull request to the merge queue Mar 25, 2025
Merged via the queue into open-telemetry:main with commit 7275cdd Mar 25, 2025
51 of 56 checks passed
@bogdandrutu bogdandrutu deleted the deprecate-blocking branch March 25, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants