Skip to content

Commit 5631f36

Browse files
committed
remove providers and converters from moduleinfo struct
1 parent b482d6e commit 5631f36

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

.chloggen/jackgopack4-add-providers-converters-moduleinfos-command.yaml renamed to .chloggen/jackgopack4-add-converters-component-command.yaml

+4-4
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,18 @@
44
change_type: enhancement
55

66
# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
7-
component: otelcol, service
7+
component: otelcol
88

99
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10-
note: Converters are now available in the component command. Additionally, Converters and Providers are listed in ModuleInfos in service host implementation
10+
note: Converters are now available in the `components` command.
1111

1212
# One or more tracking issues or pull requests related to the change
13-
issues: [11900, 12372, 12375, 12385]
13+
issues: [11900, 12385]
1414

1515
# (Optional) One or more lines of additional information to render under the primary note.
1616
# These lines will be padded with 2 spaces and then inserted directly into the document.
1717
# Use pipe (|) for multiline entries.
18-
subtext:
18+
subtext: Converters must now implement the "Type()" function to return type
1919

2020
# Optional: The change log or logs in which this entry should be included.
2121
# e.g. '[user]' or '[user, api]'

otelcol/collector.go

-2
Original file line numberDiff line numberDiff line change
@@ -215,8 +215,6 @@ func (col *Collector) setupConfigurationComponents(ctx context.Context) error {
215215
Exporter: buildModuleInfo(factories.ExporterModules),
216216
Extension: buildModuleInfo(factories.ExtensionModules),
217217
Connector: buildModuleInfo(factories.ConnectorModules),
218-
Provider: buildModuleInfo(col.set.ProviderModules),
219-
Converter: buildModuleInfo(col.set.ConverterModules),
220218
},
221219
AsyncErrorChannel: col.asyncErrorChannel,
222220
LoggingOptions: col.set.LoggingOptions,

service/internal/moduleinfo/moduleinfo.go

-2
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,4 @@ type ModuleInfos struct {
1717
Exporter map[component.Type]ModuleInfo
1818
Extension map[component.Type]ModuleInfo
1919
Connector map[component.Type]ModuleInfo
20-
Provider map[component.Type]ModuleInfo
21-
Converter map[component.Type]ModuleInfo
2220
}

0 commit comments

Comments
 (0)