Skip to content

Commit 362db71

Browse files
Preallocate a map of the right size in pcommon Map.AsRaw() (#12406)
#### Description We are seeing pcommon/Map.AsRaw() show up in the memory profiles. This PR ensure we pre-allocate a map[string]any of the expected size, instead of just an empty map. --------- Co-authored-by: Bogdan Drutu <[email protected]>
1 parent cffb7b6 commit 362db71

File tree

2 files changed

+26
-1
lines changed

2 files changed

+26
-1
lines changed
+25
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: enhancement
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
7+
component: pcommon.Map
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: preallocate go map in Map.AsRaw()
11+
12+
# One or more tracking issues or pull requests related to the change
13+
issues: [12406]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# Optional: The change log or logs in which this entry should be included.
21+
# e.g. '[user]' or '[user, api]'
22+
# Include 'user' if the change is relevant to end users.
23+
# Include 'api' if there is a change to a library API.
24+
# Default: '[user]'
25+
change_logs: [api]

pdata/pcommon/map.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ func (m Map) CopyTo(dest Map) {
263263

264264
// AsRaw returns a standard go map representation of this Map.
265265
func (m Map) AsRaw() map[string]any {
266-
rawMap := make(map[string]any)
266+
rawMap := make(map[string]any, m.Len())
267267
m.Range(func(k string, v Value) bool {
268268
rawMap[k] = v.AsRaw()
269269
return true

0 commit comments

Comments
 (0)