-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add Token expiry buffer for oauth2clientauthextension #35148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Sounds like a valid request to me. Are you open to sending a PR with this change? |
@jpkrohling I have a pr ready to be submitted, let me push it through, testing free things Thanks 🙏 |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Component(s)
extension/oauth2clientauth
Is your feature request related to a problem? Please describe.
There is a risk that the oauth token expired right after the request being sent and causing a data loss.
Describe the solution you'd like
Add a config for expiry buffer. The change would be like replace the ReuseTokenSource with ReuseTokenSourceWithExpiry and add a config for the expiry. Optional to provide a default expiry buffer
ref:
https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/extension/oauth2clientauthextension/clientcredentialsconfig.go#L93
https://pkg.go.dev/golang.org/x/oauth2#ReuseTokenSourceWithExpiry
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: