Change k8sattribute to return error if unset envvar is used for node_from_env_var #39447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
djaglowski,
a team,
dmitryax,
fatsheep9146,
TylerHelmuth and
ChrsMark
as code owners
bogdandrutu
force-pushed
the
ret-error-k8s
branch
from
984fab9 to
ccdaf55
Compare
github-actions
bot
added
receiver/journald
processor/k8sattributes
dmitryax
approved these changes
Apr 15, 2025
bogdandrutu
force-pushed
the
ret-error-k8s
branch
from
ccdaf55 to
2ac06a6
Compare
…from_env_var Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
ret-error-k8s
branch
from
2ac06a6 to
bbb6493
Compare
akshays-19
pushed a commit
to akshays-19/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2025
…from_env_var (open-telemetry#39447) Signed-off-by: Bogdan Drutu <[email protected]>
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…from_env_var (open-telemetry#39447) Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.