-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add cloud account ID detection in EKS environment #37179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dmitryax
merged 4 commits into
open-telemetry:main
from
tilakchowdary:eks_cloud_account_id
Jan 15, 2025
Merged
Add cloud account ID detection in EKS environment #37179
dmitryax
merged 4 commits into
open-telemetry:main
from
tilakchowdary:eks_cloud_account_id
Jan 15, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44393e8
to
6f758a9
Compare
dmitryax
reviewed
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment. Otherwise LGTM
processor/resourcedetectionprocessor/internal/aws/eks/metadata.yaml
Outdated
Show resolved
Hide resolved
dmitryax
approved these changes
Jan 15, 2025
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Jan 26, 2025
#### Description This enhancement detects AWS EKS cloud account ID. Account ID is obtained by querying the EC2 Metadata service for the Instance Identity Document and extracting the AccountID field from this document #### Testing Manual testing in EKS cluster with EC2 instances. Unit tests for basic functionality #### Documentation Updated metadata
zeck-ops
pushed a commit
to zeck-ops/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2025
#### Description This enhancement detects AWS EKS cloud account ID. Account ID is obtained by querying the EC2 Metadata service for the Instance Identity Document and extracting the AccountID field from this document #### Testing Manual testing in EKS cluster with EC2 instances. Unit tests for basic functionality #### Documentation Updated metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This enhancement detects AWS EKS cloud account ID.
Account ID is obtained by querying the EC2 Metadata service for the Instance Identity Document and extracting the AccountID field from this document
Testing
Manual testing in EKS cluster with EC2 instances. Unit tests for basic functionality
Documentation
Updated metadata