Remove the extra MuteProcessAllErrors added for easy benchmarking

Author: pjanotti

receiver/hostmetricsreceiver/internal/scraper/processscraper/process_metadata_benchmark_test.go

@@ -16,11 +16,7 @@ import (
 
 func BenchmarkGetProcessMetadata(b *testing.B) {
 	ctx := context.Background()
-	config := &Config{
-		MuteProcessExeError:  true,
-		MuteProcessNameError: true,
-		MuteProcessAllErrors: true, // Only way to pass the benchmark
-	}
+	config := &Config{}
 
 	scraper, err := newProcessScraper(scraper.Settings{}, config)
 	if err != nil {
@@ -61,10 +57,8 @@ func BenchmarkGetProcessMetadata(b *testing.B) {
 			scraper.config.MetricsBuilderConfig.ResourceAttributes.ProcessParentPid.Enabled = bm.parentPidEnabled
 
 			for i := 0; i < b.N; i++ {
-				_, err := scraper.getProcessMetadata(ctx)
-				if err != nil {
-					b.Fatalf("Failed to get process metadata: %v", err)
-				}
+				// Typically there are errors, but we are not interested in them for this benchmark
+				_, _ = scraper.getProcessMetadata(ctx)
 			}
 		})
 	}

receiver/hostmetricsreceiver/internal/scraper/processscraper/process_scraper.go

@@ -250,7 +250,7 @@ func (s *processScraper) getProcessMetadata(ctx context.Context) ([]*processMeta
 		}
 
 		command, err := getProcessCommand(ctx, handle)
-		if err != nil && !s.config.MuteProcessAllErrors {
+		if err != nil {
 			errs.AddPartial(0, fmt.Errorf("error reading command for process %q (pid %v): %w", executable.name, pid, err))
 		}