[connector/routing] Mark MutatesData: true

Author: djaglowski

.chloggen/routing-fix-mutates-data.yaml

@@ -0,0 +1,27 @@
+# Use this changelog template to create an entry for release notes.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: 'bug_fix'
+
+# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
+component: routingconnector
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: The connector splits the original payload so that it may be emitted in parts to each route.
+
+# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
+issues: [37390]
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext:
+
+# If your change doesn't affect end users or the exported elements of any package,
+# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
+# Optional: The change log or logs in which this entry should be included.
+# e.g. '[user]' or '[user, api]'
+# Include 'user' if the change is relevant to end users.
+# Include 'api' if there is a change to a library API.
+# Default: '[user]'
+change_logs: []

connector/routingconnector/logs.go

@@ -61,7 +61,7 @@ func newLogsConnector(
 }
 
 func (c *logsConnector) Capabilities() consumer.Capabilities {
-	return consumer.Capabilities{MutatesData: false}
+	return consumer.Capabilities{MutatesData: true}
 }
 
 func (c *logsConnector) ConsumeLogs(ctx context.Context, ld plog.Logs) error {

connector/routingconnector/logs_test.go

@@ -413,7 +413,7 @@ func TestLogsConnectorCapabilities(t *testing.T) {
 	)
 
 	require.NoError(t, err)
-	assert.False(t, conn.Capabilities().MutatesData)
+	assert.True(t, conn.Capabilities().MutatesData)
 }
 
 func TestLogsConnectorDetailed(t *testing.T) {

connector/routingconnector/metrics.go

@@ -62,7 +62,7 @@ func newMetricsConnector(
 }
 
 func (c *metricsConnector) Capabilities() consumer.Capabilities {
-	return consumer.Capabilities{MutatesData: false}
+	return consumer.Capabilities{MutatesData: true}
 }
 
 func (c *metricsConnector) ConsumeMetrics(ctx context.Context, md pmetric.Metrics) error {

connector/routingconnector/metrics_test.go

@@ -435,7 +435,7 @@ func TestMetricsConnectorCapabilities(t *testing.T) {
 	)
 
 	require.NoError(t, err)
-	assert.False(t, conn.Capabilities().MutatesData)
+	assert.True(t, conn.Capabilities().MutatesData)
 }
 
 func TestMetricsConnectorDetailed(t *testing.T) {

connector/routingconnector/traces.go

@@ -61,7 +61,7 @@ func newTracesConnector(
 }
 
 func (*tracesConnector) Capabilities() consumer.Capabilities {
-	return consumer.Capabilities{MutatesData: false}
+	return consumer.Capabilities{MutatesData: true}
 }
 
 func (c *tracesConnector) ConsumeTraces(ctx context.Context, td ptrace.Traces) error {

connector/routingconnector/traces_test.go

@@ -393,7 +393,7 @@ func TestTraceConnectorCapabilities(t *testing.T) {
 	)
 
 	require.NoError(t, err)
-	assert.False(t, conn.Capabilities().MutatesData)
+	assert.True(t, conn.Capabilities().MutatesData)
 }
 
 func TestTracesConnectorDetailed(t *testing.T) {

pkg/stanza/fileconsumer/file.go

@@ -105,9 +105,12 @@ func (m *Manager) startPoller(ctx context.Context) {
 			case <-ctx.Done():
 				return
 			case <-globTicker.C:
+				m.set.Logger.Debug("tick")
 			}
 
+			m.set.Logger.Debug("poll start")
 			m.poll(ctx)
+			m.set.Logger.Debug("poll end")
 		}
 	}()
 }
@@ -248,11 +251,13 @@ func (m *Manager) newReader(ctx context.Context, file *os.File, fp *fingerprint.
 					zap.String("rotated_path", file.Name()))
 			}
 		}
+		m.set.Logger.Debug("Found already open file", zap.Int64("offset", oldReader.Offset))
 		return m.readerFactory.NewReaderFromMetadata(file, oldReader.Close())
 	}
 
 	// Check for closed files for match
 	if oldMetadata := m.tracker.GetClosedFile(fp); oldMetadata != nil {
+		m.set.Logger.Debug("Found previously closed file", zap.Int64("offset", oldMetadata.Offset))
 		r, err := m.readerFactory.NewReaderFromMetadata(file, oldMetadata)
 		if err != nil {
 			return nil, err

pkg/stanza/operator/parser/jsonarray/parser.go

@@ -8,6 +8,7 @@ import (
 	"fmt"
 
 	"github.com/valyala/fastjson"
+	"go.uber.org/zap"
 
 	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/entry"
 	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/operator/helper"
@@ -23,7 +24,12 @@ type parseFunc func(any) (any, error)
 
 // Process will parse an entry for json array.
 func (p *Parser) Process(ctx context.Context, e *entry.Entry) error {
-	return p.ParserOperator.ProcessWith(ctx, e, p.parse)
+	err := p.ParserOperator.ProcessWith(ctx, e, p.parse)
+	if err == nil {
+		return nil
+	}
+	p.Logger().Error("json_array_parser", zap.Error(err))
+	return err
 }
 
 func generateParseToArrayFunc(pool *fastjson.ParserPool) parseFunc {