Skip to content

locale.getdefaultlocale() is deprecated #3563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jwodder opened this issue Apr 10, 2023 · 1 comment · Fixed by #3590
Closed

locale.getdefaultlocale() is deprecated #3563

jwodder opened this issue Apr 10, 2023 · 1 comment · Fixed by #3590

Comments

@jwodder
Copy link
Member

jwodder commented Apr 10, 2023

nipype uses the locale.getdefaultlocale() function here and here. However, this function was deprecated in Python 3.11 and will be removed in Python 3.13. It should be replaced with either locale.getpreferredencoding() or locale.getencoding().
@effigies
Copy link
Member

I guesss getpreferredencoding is the better option for now, as we getencoding() is 3.11+. Unless there's an argument for using getencoding and having a fallback?

@effigies effigies mentioned this issue Jul 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MNT: Replace deprecated locale.getdefaultlocale effigies/nipype
2 participants
@effigies @jwodder