feat: update get signature
#23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for blobs-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
type: feature
eduardoboucas
commented
Jul 26, 2023
src/main.ts
Outdated
| async get(key: string, { type }: { type: 'blob' }): Promise<Blob> | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| async get(key: string, { type }: { type: 'json' }): Promise<any> | ||
| async get(key: string, { type }: { type: 'stream' }): Promise<ReadableStream | null> |
There was a problem hiding this comment.
how come this is the only one that can resolve to null?
There was a problem hiding this comment.
Oops! Good catch. That shouldn't be the case. Fixed in 55f9223.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this pull request solving?
Updates the
typeproperty of thegetmethod to use a union rather than an enum, to prevent this from happening:Also adds the overload for
{type: "json"}which is currently missing.