Skip to content

Commit f2dc09f

Browse files
committed
PHPLIB-1326: Use more permissive top-level runOnRequirements
Synced with mongodb/specifications@4c73bb1
1 parent be1e9e9 commit f2dc09f

File tree

3 files changed

+41
-38
lines changed

3 files changed

+41
-38
lines changed

tests/UnifiedSpecTests/retryable-writes/bulkWrite-serverErrors.json

+7-15
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,16 @@
33
"schemaVersion": "1.0",
44
"runOnRequirements": [
55
{
6-
"minServerVersion": "3.6",
6+
"minServerVersion": "4.0",
77
"topologies": [
88
"replicaset"
99
]
10+
},
11+
{
12+
"minServerVersion": "4.1.7",
13+
"topologies": [
14+
"sharded"
15+
]
1016
}
1117
],
1218
"createEntities": [
@@ -53,20 +59,6 @@
5359
"tests": [
5460
{
5561
"description": "BulkWrite succeeds after retryable writeConcernError in first batch",
56-
"runOnRequirements": [
57-
{
58-
"minServerVersion": "4.0",
59-
"topologies": [
60-
"replicaset"
61-
]
62-
},
63-
{
64-
"minServerVersion": "4.1.7",
65-
"topologies": [
66-
"sharded"
67-
]
68-
}
69-
],
7062
"operations": [
7163
{
7264
"name": "failPoint",

tests/UnifiedSpecTests/retryable-writes/insertOne-serverErrors.json

+7-15
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,16 @@
33
"schemaVersion": "1.0",
44
"runOnRequirements": [
55
{
6-
"minServerVersion": "3.6",
6+
"minServerVersion": "4.0",
77
"topologies": [
88
"replicaset"
99
]
10+
},
11+
{
12+
"minServerVersion": "4.1.7",
13+
"topologies": [
14+
"sharded"
15+
]
1016
}
1117
],
1218
"createEntities": [
@@ -53,20 +59,6 @@
5359
"tests": [
5460
{
5561
"description": "InsertOne succeeds after retryable writeConcernError",
56-
"runOnRequirements": [
57-
{
58-
"minServerVersion": "4.0",
59-
"topologies": [
60-
"replicaset"
61-
]
62-
},
63-
{
64-
"minServerVersion": "4.1.7",
65-
"topologies": [
66-
"sharded"
67-
]
68-
}
69-
],
7062
"operations": [
7163
{
7264
"name": "failPoint",

tests/UnifiedSpecTests/valid-pass/poc-retryable-writes.json

+27-8
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,6 @@
11
{
22
"description": "poc-retryable-writes",
33
"schemaVersion": "1.0",
4-
"runOnRequirements": [
5-
{
6-
"minServerVersion": "3.6",
7-
"topologies": [
8-
"replicaset"
9-
]
10-
}
11-
],
124
"createEntities": [
135
{
146
"client": {
@@ -79,6 +71,14 @@
7971
"tests": [
8072
{
8173
"description": "FindOneAndUpdate is committed on first attempt",
74+
"runOnRequirements": [
75+
{
76+
"minServerVersion": "3.6",
77+
"topologies": [
78+
"replicaset"
79+
]
80+
}
81+
],
8282
"operations": [
8383
{
8484
"name": "failPoint",
@@ -132,6 +132,14 @@
132132
},
133133
{
134134
"description": "FindOneAndUpdate is not committed on first attempt",
135+
"runOnRequirements": [
136+
{
137+
"minServerVersion": "3.6",
138+
"topologies": [
139+
"replicaset"
140+
]
141+
}
142+
],
135143
"operations": [
136144
{
137145
"name": "failPoint",
@@ -188,6 +196,14 @@
188196
},
189197
{
190198
"description": "FindOneAndUpdate is never committed",
199+
"runOnRequirements": [
200+
{
201+
"minServerVersion": "3.6",
202+
"topologies": [
203+
"replicaset"
204+
]
205+
}
206+
],
191207
"operations": [
192208
{
193209
"name": "failPoint",
@@ -433,6 +449,9 @@
433449
"failCommands": [
434450
"insert"
435451
],
452+
"errorLabels": [
453+
"RetryableWriteError"
454+
],
436455
"writeConcernError": {
437456
"code": 91,
438457
"errmsg": "Replication is being shut down"

0 commit comments

Comments
 (0)