chore: update tap@19 (fastify#5471)

* chore: update tap@18

* chore: tap@19

* chore: remove c8

* chore: remove ignore

Author: climba03003

.c8rc.json

@@ -33,7 +33,7 @@ jobs:
         if: ${{ success() }}
         with:
           name: coverage-report-nix
-          path: ./coverage/lcov-report/
+          path: ./.tap/report/
 
       # Here, we verify the coverage thresholds so that this workflow can pass
       # or fail and stop further workflows if this one fails.

.github/workflows/coverage-nix.yml

@@ -33,7 +33,7 @@ jobs:
         if: ${{ success() }}
         with:
           name: coverage-report-win
-          path: ./coverage/lcov-report/
+          path: ./.tap/report/
 
       # Here, we verify the coverage thresholds so that this workflow can pass
       # or fail and stop further workflows if this one fails.

.github/workflows/coverage-win.yml

@@ -1,11 +1,7 @@
-ts: false
-jsx: false
-flow: false
-# the coverage is performed by c8
-check-coverage: false
-coverage: false
-node-arg: --allow-natives-syntax
+# vim: set filetype=yaml :
+node-arg:
+  - '--allow-natives-syntax'
 
-files:
+include:
   - 'test/**/*.test.js'
   - 'test/**/*.test.mjs'

.taprc

@@ -18,10 +18,12 @@ const code = FJS({
 const file = path.join(__dirname, '..', 'lib', 'error-serializer.js')
 
 const moduleCode = `// This file is autogenerated by build/build-error-serializer.js, do not edit
-/* istanbul ignore file */
+/* c8 ignore start */
 ${code}
+/* c8 ignore stop */
 `
 
+/* c8 ignore start */
 if (require.main === module) {
   fs.writeFileSync(file, moduleCode)
   console.log(`Saved ${file} file successfully`)
@@ -30,3 +32,4 @@ if (require.main === module) {
     code: moduleCode
   }
 }
+/* c8 ignore stop */

build/build-error-serializer.js

@@ -9,10 +9,11 @@ const factory = AjvStandaloneCompiler({
   readMode: false,
   storeFunction (routeOpts, schemaValidationCode) {
     const moduleCode = `// This file is autogenerated by ${__filename.replace(__dirname, 'build')}, do not edit
-/* istanbul ignore file */
+/* c8 ignore start */
 ${schemaValidationCode}
 
 module.exports.defaultInitOptions = ${JSON.stringify(defaultInitOptions)}
+/* c8 ignore stop */
 `
 
     const file = path.join(__dirname, '..', 'lib', 'configValidator.js')

build/build-validation.js

@@ -1,5 +1,5 @@
 // This file is autogenerated by build/build-validation.js, do not edit
-/* istanbul ignore file */
+/* c8 ignore start */
 "use strict";
 module.exports = validate10;
 module.exports.default = validate10;
@@ -1153,3 +1153,4 @@ return errors === 0;
 
 
 module.exports.defaultInitOptions = {"connectionTimeout":0,"keepAliveTimeout":72000,"maxRequestsPerSocket":0,"requestTimeout":0,"bodyLimit":1048576,"caseSensitive":true,"allowUnsafeRegex":false,"disableRequestLogging":false,"jsonShorthand":true,"ignoreTrailingSlash":false,"ignoreDuplicateSlashes":false,"maxParamLength":100,"onProtoPoisoning":"error","onConstructorPoisoning":"error","pluginTimeout":10000,"requestIdHeader":false,"requestIdLogLabel":"reqId","http2SessionTimeout":72000,"exposeHeadRoutes":true,"useSemicolonDelimiter":false}
+/* c8 ignore stop */

lib/configValidator.js

@@ -1,11 +1,9 @@
 // This file is autogenerated by build/build-error-serializer.js, do not edit
-/* istanbul ignore file */
+/* c8 ignore start */
 
   'use strict'
-  const { dependencies } = require('fast-json-stringify/lib/standalone')
-
-  const { Serializer, Validator } = dependencies
 
+  const Serializer = require('fast-json-stringify/lib/serializer')
   const serializerState = {"mode":"standalone"}
   const serializer = Serializer.restoreFromState(serializerState)
 
@@ -15,6 +13,18 @@
   module.exports = function anonymous(validator,serializer
 ) {
 
+    const JSON_STR_BEGIN_OBJECT = '{'
+    const JSON_STR_END_OBJECT = '}'
+    const JSON_STR_BEGIN_ARRAY = '['
+    const JSON_STR_END_ARRAY = ']'
+    const JSON_STR_COMMA = ','
+    const JSON_STR_COLONS = ':'
+    const JSON_STR_QUOTE = '"'
+    const JSON_STR_EMPTY_OBJECT = JSON_STR_BEGIN_OBJECT + JSON_STR_END_OBJECT
+    const JSON_STR_EMPTY_ARRAY = JSON_STR_BEGIN_ARRAY + JSON_STR_END_ARRAY
+    const JSON_STR_EMPTY_STRING = JSON_STR_QUOTE + JSON_STR_QUOTE
+    const JSON_STR_NULL = 'null'
+  
 
 
     // #
@@ -23,40 +33,88 @@
     ? input.toJSON()
     : input
 
-      if (obj === null) return '{}'
+      if (obj === null) return JSON_STR_EMPTY_OBJECT
 
-      let json = '{'
+      let value
+let json = JSON_STR_BEGIN_OBJECT
 let addComma = false
 
-      if (obj["statusCode"] !== undefined) {
-        !addComma && (addComma = true) || (json += ',')
+      value = obj["statusCode"]
+      if (value !== undefined) {
+        !addComma && (addComma = true) || (json += JSON_STR_COMMA)
         json += "\"statusCode\":"
-        json += serializer.asNumber(obj["statusCode"])
+        json += serializer.asNumber(value)
       }
 
-      if (obj["code"] !== undefined) {
-        !addComma && (addComma = true) || (json += ',')
+      value = obj["code"]
+      if (value !== undefined) {
+        !addComma && (addComma = true) || (json += JSON_STR_COMMA)
         json += "\"code\":"
-        json += serializer.asString(obj["code"])
+        
+        if (typeof value !== 'string') {
+          if (value === null) {
+            json += JSON_STR_EMPTY_STRING
+          } else if (value instanceof Date) {
+            json += JSON_STR_QUOTE + value.toISOString() + JSON_STR_QUOTE
+          } else if (value instanceof RegExp) {
+            json += serializer.asString(value.source)
+          } else {
+            json += serializer.asString(value.toString())
+          }
+        } else {
+          json += serializer.asString(value)
+        }
+        
       }
 
-      if (obj["error"] !== undefined) {
-        !addComma && (addComma = true) || (json += ',')
+      value = obj["error"]
+      if (value !== undefined) {
+        !addComma && (addComma = true) || (json += JSON_STR_COMMA)
         json += "\"error\":"
-        json += serializer.asString(obj["error"])
+        
+        if (typeof value !== 'string') {
+          if (value === null) {
+            json += JSON_STR_EMPTY_STRING
+          } else if (value instanceof Date) {
+            json += JSON_STR_QUOTE + value.toISOString() + JSON_STR_QUOTE
+          } else if (value instanceof RegExp) {
+            json += serializer.asString(value.source)
+          } else {
+            json += serializer.asString(value.toString())
+          }
+        } else {
+          json += serializer.asString(value)
+        }
+        
       }
 
-      if (obj["message"] !== undefined) {
-        !addComma && (addComma = true) || (json += ',')
+      value = obj["message"]
+      if (value !== undefined) {
+        !addComma && (addComma = true) || (json += JSON_STR_COMMA)
         json += "\"message\":"
-        json += serializer.asString(obj["message"])
+        
+        if (typeof value !== 'string') {
+          if (value === null) {
+            json += JSON_STR_EMPTY_STRING
+          } else if (value instanceof Date) {
+            json += JSON_STR_QUOTE + value.toISOString() + JSON_STR_QUOTE
+          } else if (value instanceof RegExp) {
+            json += serializer.asString(value.source)
+          } else {
+            json += serializer.asString(value.toString())
+          }
+        } else {
+          json += serializer.asString(value)
+        }
+        
       }
 
-    return json + '}'
+    return json + JSON_STR_END_OBJECT
 
     }
 
     const main = anonymous0
     return main
 
 }(validator, serializer)
+/* c8 ignore stop */

lib/error-serializer.js

@@ -11,24 +11,24 @@
     "benchmark:parser": "concurrently -k -s first \"node ./examples/benchmark/parser.js\" \"autocannon -c 100 -d 30 -p 10 -i ./examples/benchmark/body.json -H \"content-type:application/jsoff\" -m POST localhost:3000/\"",
     "build:validation": "node build/build-error-serializer.js && node build/build-validation.js",
     "coverage": "npm run unit -- --coverage-report=html",
-    "coverage:ci": "c8 --reporter=lcov tap --coverage-report=html --no-browser --no-check-coverage",
-    "coverage:ci-check-coverage": "c8 check-coverage --branches 100 --functions 100 --lines 100 --statements 100",
+    "coverage:ci": "tap --coverage-report=html --coverage-report=lcov --allow-incomplete-coverage",
+    "coverage:ci-check-coverage": "tap replay",
     "lint": "npm run lint:standard && npm run lint:typescript && npm run lint:markdown",
     "lint:fix": "standard --fix && npm run lint:typescript:fix",
     "lint:markdown": "markdownlint-cli2",
     "lint:standard": "standard | snazzy",
     "lint:typescript": "eslint -c types/.eslintrc.json types/**/*.d.ts test/types/**/*.test-d.ts",
     "lint:typescript:fix": "npm run lint:typescript -- --fix",
-    "prepublishOnly": "cross-env PREPUBLISH=true tap --no-check-coverage test/build/**.test.js && npm run test:validator:integrity",
+    "prepublishOnly": "cross-env PREPUBLISH=true tap --allow-incomplete-coverage test/build/**.test.js && npm run test:validator:integrity",
     "test": "npm run lint && npm run unit && npm run test:typescript",
-    "test:ci": "npm run unit -- --cov --coverage-report=lcovonly && npm run test:typescript",
+    "test:ci": "npm run unit -- --coverage-report=lcovonly && npm run test:typescript",
     "test:report": "npm run lint && npm run unit:report && npm run test:typescript",
     "test:validator:integrity": "npm run build:validation && git diff --quiet --ignore-all-space --ignore-blank-lines --ignore-cr-at-eol lib/error-serializer.js && git diff --quiet --ignore-all-space --ignore-blank-lines --ignore-cr-at-eol lib/configValidator.js",
     "test:typescript": "tsc test/types/import.ts && tsd",
-    "test:watch": "npm run unit -- --watch --cov --no-coverage-report --reporter=terse",
-    "unit": "c8 tap",
+    "test:watch": "npm run unit -- --watch --coverage-report=none --reporter=terse",
+    "unit": "tap",
     "unit:junit": "tap-mocha-reporter xunit < out.tap > test/junit-testresults.xml",
-    "unit:report": "tap --cov --coverage-report=html --coverage-report=cobertura | tee out.tap",
+    "unit:report": "tap --coverage-report=html --coverage-report=cobertura | tee out.tap",
     "citgm": "tap --jobs=1 --timeout=120"
   },
   "repository": {
@@ -167,7 +167,6 @@
     "ajv-merge-patch": "^5.0.1",
     "autocannon": "^7.15.0",
     "branch-comparer": "^1.1.0",
-    "c8": "^9.1.0",
     "concurrently": "^8.2.2",
     "cross-env": "^7.0.3",
     "eslint": "^8.57.0",
@@ -193,7 +192,7 @@
     "snazzy": "^9.0.0",
     "split2": "^4.2.0",
     "standard": "^17.1.0",
-    "tap": "^16.3.9",
+    "tap": "^19.0.0",
     "tsd": "^0.31.0",
     "typescript": "^5.4.5",
     "undici": "^6.13.0",

package.json

@@ -1415,9 +1415,9 @@ test('.statusCode is getter and setter', t => {
   const fastify = Fastify()
 
   fastify.get('/', function (req, reply) {
-    t.ok(reply.statusCode, 200, 'default status value')
+    t.equal(reply.statusCode, 200, 'default status value')
     reply.statusCode = 418
-    t.ok(reply.statusCode, 418)
+    t.equal(reply.statusCode, 418)
     reply.send()
   })