From 976deb65d32f4e0ae0c165671430165ebfcd9c51 Mon Sep 17 00:00:00 2001 From: Cari Spruiell Date: Mon, 1 Apr 2019 10:32:31 -0500 Subject: [PATCH 1/2] MC-5894: Gift Card Account --- Magento2/Sniffs/Security/InsecureFunctionSniff.php | 1 + 1 file changed, 1 insertion(+) diff --git a/Magento2/Sniffs/Security/InsecureFunctionSniff.php b/Magento2/Sniffs/Security/InsecureFunctionSniff.php index 68b09382..b432f454 100644 --- a/Magento2/Sniffs/Security/InsecureFunctionSniff.php +++ b/Magento2/Sniffs/Security/InsecureFunctionSniff.php @@ -39,5 +39,6 @@ class InsecureFunctionSniff extends ForbiddenFunctionsSniff 'unserialize' => '\Magento\Framework\Serialize\SerializerInterface::unserialize', 'srand' => null, 'mt_srand'=> null, + 'mt_rand' => 'random_int', ]; } From 575acb6ff7e39630502bb7b4e0ec37089a6e5f41 Mon Sep 17 00:00:00 2001 From: Cari Spruiell Date: Mon, 29 Apr 2019 11:51:34 -0500 Subject: [PATCH 2/2] MC-5894: Gift Card Account --- Magento2/Tests/Security/InsecureFunctionUnitTest.inc | 2 ++ Magento2/Tests/Security/InsecureFunctionUnitTest.php | 1 + 2 files changed, 3 insertions(+) diff --git a/Magento2/Tests/Security/InsecureFunctionUnitTest.inc b/Magento2/Tests/Security/InsecureFunctionUnitTest.inc index a502580a..db0a0c4e 100644 --- a/Magento2/Tests/Security/InsecureFunctionUnitTest.inc +++ b/Magento2/Tests/Security/InsecureFunctionUnitTest.inc @@ -27,3 +27,5 @@ pcntl_exec('path/goes/here'); srand(); mt_srand(); + +mt_rand(); diff --git a/Magento2/Tests/Security/InsecureFunctionUnitTest.php b/Magento2/Tests/Security/InsecureFunctionUnitTest.php index 5a35a8d2..c7b8210e 100644 --- a/Magento2/Tests/Security/InsecureFunctionUnitTest.php +++ b/Magento2/Tests/Security/InsecureFunctionUnitTest.php @@ -40,6 +40,7 @@ public function getWarningList() 25 => 1, 27 => 1, 29 => 1, + 31 => 1, ]; } }