From f2bb5ec52fbc518f68799ee0cefda662ab22c66d Mon Sep 17 00:00:00 2001
From: Lars Roettig <l.roettig@techdivision.com>
Date: Sun, 3 Mar 2019 23:23:10 +0100
Subject: [PATCH] #49 Impl. LocalizedException SHOULD only be thrown in View

---
 .../Sniffs/Exceptions/LocalizedThrowSniff.php | 78 +++++++++++++++++++
 .../Exceptions/LocalizedThrowUnitTest.1.inc   | 28 +++++++
 .../Exceptions/LocalizedThrowUnitTest.2.inc   | 22 ++++++
 .../Exceptions/LocalizedThrowUnitTest.3.inc   | 20 +++++
 .../Exceptions/LocalizedThrowUnitTest.4.inc   | 14 ++++
 .../Exceptions/LocalizedThrowUnitTest.5.inc   | 13 ++++
 .../Exceptions/LocalizedThrowUnitTest.php     | 38 +++++++++
 Magento/ruleset.xml                           |  4 +
 8 files changed, 217 insertions(+)
 create mode 100644 Magento/Sniffs/Exceptions/LocalizedThrowSniff.php
 create mode 100644 Magento/Tests/Exceptions/LocalizedThrowUnitTest.1.inc
 create mode 100644 Magento/Tests/Exceptions/LocalizedThrowUnitTest.2.inc
 create mode 100644 Magento/Tests/Exceptions/LocalizedThrowUnitTest.3.inc
 create mode 100644 Magento/Tests/Exceptions/LocalizedThrowUnitTest.4.inc
 create mode 100644 Magento/Tests/Exceptions/LocalizedThrowUnitTest.5.inc
 create mode 100644 Magento/Tests/Exceptions/LocalizedThrowUnitTest.php

diff --git a/Magento/Sniffs/Exceptions/LocalizedThrowSniff.php b/Magento/Sniffs/Exceptions/LocalizedThrowSniff.php
new file mode 100644
index 00000000..416a1b4e
--- /dev/null
+++ b/Magento/Sniffs/Exceptions/LocalizedThrowSniff.php
@@ -0,0 +1,78 @@
+<?php
+/**
+ * Copyright © Magento. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\Sniffs\Exceptions;
+
+use PHP_CodeSniffer\Sniffs\Sniff;
+use PHP_CodeSniffer\Files\File;
+
+/**
+ * Detects possible direct throws of Exceptions.
+ */
+class LocalizedThrowSniff implements Sniff
+{
+
+    protected $presentationLayerKeys = ['Controller', 'Block', 'ViewModel'];
+
+    /**
+     * String representation of warning.
+     */
+    protected $warningMessage = 'LocalizedException SHOULD only be thrown in the Presentation layer.';
+
+    /**
+     * Warning violation code.
+     *
+     * @var string
+     */
+    protected $warningCode = 'LocalizedThrow';
+
+    /**
+     * @inheritdoc
+     */
+    public function register()
+    {
+        return [T_THROW];
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function process(File $phpcsFile, $stackPtr)
+    {
+        $lineEnd = $phpcsFile->findNext(T_OPEN_PARENTHESIS, $stackPtr);
+        $exceptionType = $phpcsFile->getTokensAsString($stackPtr, $lineEnd);
+
+        // throw is not a LocalizedException nothing to do
+        if (strpos($exceptionType, 'LocalizedException') === false) {
+            return;
+        }
+
+        $nameSpaceTag = $phpcsFile->findPrevious(T_NAMESPACE, $stackPtr, 0);
+        if ($nameSpaceTag === false) {
+            // no namespace nothing to do
+            return;
+        }
+
+        $lineEnd = $phpcsFile->findNext(T_SEMICOLON, $nameSpaceTag);
+        $nameSpaceString = $phpcsFile->getTokensAsString($nameSpaceTag, $lineEnd);
+
+        $isPresentationLayer = false;
+        foreach ($this->presentationLayerKeys as $layerKey) {
+            if (strpos($nameSpaceString, $layerKey) !== false) {
+                $isPresentationLayer = true;
+                break;
+            }
+        }
+
+        if (!$isPresentationLayer) {
+            $phpcsFile->addWarning(
+                $this->warningMessage,
+                $stackPtr,
+                $this->warningCode
+            );
+        }
+    }
+}
diff --git a/Magento/Tests/Exceptions/LocalizedThrowUnitTest.1.inc b/Magento/Tests/Exceptions/LocalizedThrowUnitTest.1.inc
new file mode 100644
index 00000000..61dc361d
--- /dev/null
+++ b/Magento/Tests/Exceptions/LocalizedThrowUnitTest.1.inc
@@ -0,0 +1,28 @@
+<?php
+/**
+ *
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\Catalog\Controller\Product;
+
+use Magento\Framework\App\Action\HttpPostActionInterface as HttpPostActionInterface;
+use Magento\Framework\App\Action\HttpGetActionInterface as HttpGetActionInterface;
+use Magento\Framework\App\Action\Context;
+use Magento\Framework\View\Result\PageFactory;
+use Magento\Catalog\Controller\Product as ProductAction;
+
+/**
+ * View a product on storefront. Needs to be accessible by POST because of the store switching.
+ */
+class View extends ProductAction implements HttpGetActionInterface, HttpPostActionInterface
+{
+    /**
+     *
+     */
+    public function execute()
+    {
+        throw new LocalizedException(__('%1 doesn\'t exists'));
+    }
+}
diff --git a/Magento/Tests/Exceptions/LocalizedThrowUnitTest.2.inc b/Magento/Tests/Exceptions/LocalizedThrowUnitTest.2.inc
new file mode 100644
index 00000000..3edcaeb9
--- /dev/null
+++ b/Magento/Tests/Exceptions/LocalizedThrowUnitTest.2.inc
@@ -0,0 +1,22 @@
+<?php
+/**
+ *
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\Catalog\Model\Test\SubFolder;
+
+/**
+ * Class Product
+ */
+class Product
+{
+    public function execute()
+    {
+        // rule should find this
+        throw new LocalizedException(__('Cant find %1 doesn\'t exists'));
+    }
+}
+
+
diff --git a/Magento/Tests/Exceptions/LocalizedThrowUnitTest.3.inc b/Magento/Tests/Exceptions/LocalizedThrowUnitTest.3.inc
new file mode 100644
index 00000000..d572f384
--- /dev/null
+++ b/Magento/Tests/Exceptions/LocalizedThrowUnitTest.3.inc
@@ -0,0 +1,20 @@
+<?php
+/**
+ *
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\Catalog\Block\Test\SubFolder;
+
+
+/**
+ * Class Product
+ */
+class Product
+{
+    public function execute()
+    {
+        throw new LocalizedException(__('Cant find %1 doesn\'t exists'));
+    }
+}
diff --git a/Magento/Tests/Exceptions/LocalizedThrowUnitTest.4.inc b/Magento/Tests/Exceptions/LocalizedThrowUnitTest.4.inc
new file mode 100644
index 00000000..36aa71be
--- /dev/null
+++ b/Magento/Tests/Exceptions/LocalizedThrowUnitTest.4.inc
@@ -0,0 +1,14 @@
+<?php
+
+/**
+ * Class Product
+ */
+class TestViewModel
+{
+    public function execute()
+    {
+        throw new \Magento\Framework\Exception\LocalizedException(__('Oops'));
+    }
+}
+
+
diff --git a/Magento/Tests/Exceptions/LocalizedThrowUnitTest.5.inc b/Magento/Tests/Exceptions/LocalizedThrowUnitTest.5.inc
new file mode 100644
index 00000000..2cf39d91
--- /dev/null
+++ b/Magento/Tests/Exceptions/LocalizedThrowUnitTest.5.inc
@@ -0,0 +1,13 @@
+<?php
+
+namespace Magento\Catalog\Model\Test\SubFolder;
+
+class Foo
+{
+    public function execute()
+    {
+        throw new \InvalidArgumentException(__('Oops'));
+    }
+}
+
+
diff --git a/Magento/Tests/Exceptions/LocalizedThrowUnitTest.php b/Magento/Tests/Exceptions/LocalizedThrowUnitTest.php
new file mode 100644
index 00000000..34c95293
--- /dev/null
+++ b/Magento/Tests/Exceptions/LocalizedThrowUnitTest.php
@@ -0,0 +1,38 @@
+<?php
+/**
+ * Copyright © Magento. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\Tests\Exceptions;
+
+use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest;
+
+/**
+ * Class NamespaceUnitTest
+ */
+class LocalizedThrowUnitTest extends AbstractSniffUnitTest
+{
+    /**
+     * @inheritdoc
+     */
+    public function getErrorList()
+    {
+        return [
+        ];
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getWarningList($testFile = '')
+    {
+        if ($testFile === 'LocalizedThrowUnitTest.2.inc') {
+            return [
+               18 => 1
+            ];
+        }
+
+        return [];
+    }
+}
diff --git a/Magento/ruleset.xml b/Magento/ruleset.xml
index 40336962..7a635703 100644
--- a/Magento/ruleset.xml
+++ b/Magento/ruleset.xml
@@ -195,6 +195,10 @@
         <severity>7</severity>
         <type>warning</type>
     </rule>
+    <rule ref="Magento.Exceptions.LocalizedThrow">
+        <severity>7</severity>
+        <type>warning</type>
+    </rule>
     <rule ref="Magento.PHP.LiteralNamespaces">
         <severity>7</severity>
         <type>warning</type>