From 49bdbbc1a8a976f7e7dc7471a7b24a031f17b232 Mon Sep 17 00:00:00 2001 From: Philipp Sander Date: Wed, 22 May 2019 11:23:27 +0200 Subject: [PATCH 1/2] provide possible solution feedback for discouraged functions --- Magento2/Sniffs/Functions/DiscouragedFunctionSniff.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Magento2/Sniffs/Functions/DiscouragedFunctionSniff.php b/Magento2/Sniffs/Functions/DiscouragedFunctionSniff.php index 75a87654..fc7ef530 100644 --- a/Magento2/Sniffs/Functions/DiscouragedFunctionSniff.php +++ b/Magento2/Sniffs/Functions/DiscouragedFunctionSniff.php @@ -44,7 +44,7 @@ class DiscouragedFunctionSniff extends ForbiddenFunctionsSniff '^chroot$' => null, '^com_load_typelib$' => null, '^copy$' => null, - '^curl_.*$' => null, + '^curl_.*$' => '\Magento\Framework\HTTP\Adapter\Curl', '^cyrus_connect$' => null, '^dba_.*$' => null, '^dbase_.*$' => null, @@ -53,7 +53,7 @@ class DiscouragedFunctionSniff extends ForbiddenFunctionsSniff '^dcngettext$' => null, '^dgettext$' => null, '^dio_.*$' => null, - '^dirname$' => null, + '^dirname$' => '\Magento\Framework\Filesystem\Io\File::getPathInfo [\'dirname\']', '^dngettext$' => null, '^domxml_.*$' => null, '^fbsql_.*$' => null, @@ -140,7 +140,7 @@ class DiscouragedFunctionSniff extends ForbiddenFunctionsSniff '^time_nanosleep$' => null, '^base64_decode$' => null, '^base_convert$' => null, - '^basename$' => null, + '^basename$' => '\Magento\Framework\Filesystem\Io\File::getPathInfo [\'basename\']', '^chr$' => null, '^convert_cyr_string$' => null, '^dba_nextkey$' => null, From 28fbcd892fe9bdc84fbca6a36ecfd210728ebb83 Mon Sep 17 00:00:00 2001 From: Philipp Sander Date: Thu, 23 May 2019 10:35:37 +0200 Subject: [PATCH 2/2] Update Magento2/Sniffs/Functions/DiscouragedFunctionSniff.php Co-Authored-By: Alex Paliarush --- Magento2/Sniffs/Functions/DiscouragedFunctionSniff.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Magento2/Sniffs/Functions/DiscouragedFunctionSniff.php b/Magento2/Sniffs/Functions/DiscouragedFunctionSniff.php index fc7ef530..3b772935 100644 --- a/Magento2/Sniffs/Functions/DiscouragedFunctionSniff.php +++ b/Magento2/Sniffs/Functions/DiscouragedFunctionSniff.php @@ -53,7 +53,7 @@ class DiscouragedFunctionSniff extends ForbiddenFunctionsSniff '^dcngettext$' => null, '^dgettext$' => null, '^dio_.*$' => null, - '^dirname$' => '\Magento\Framework\Filesystem\Io\File::getPathInfo [\'dirname\']', + '^dirname$' => '\Magento\Framework\Filesystem\Io\File::getPathInfo($filePath)[\'dirname\']', '^dngettext$' => null, '^domxml_.*$' => null, '^fbsql_.*$' => null,