AC-669: Fixed directory name checking too lax

svera · svera · commit e81cea016571 · 2021-09-28T13:27:37.000+02:00
diff --git a/Magento2/Sniffs/Legacy/InstallUpgradeSniff.php b/Magento2/Sniffs/Legacy/InstallUpgradeSniff.php
@@ -64,7 +64,8 @@ public function process(File $phpcsFile, $stackPtr)
             }
         }
 
-        $folderName = basename($fileInfo->getPath());
+        $folders = array_filter(explode('/', $fileInfo->getPath()));
+        $folderName = array_pop($folders);
 
         if ($folderName === 'data' || $folderName === 'sql') {
             $phpcsFile->addError(

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,8 @@ public function process(File $phpcsFile, $stackPtr)`
`64`	`64`	`}`
`65`	`65`	`}`
`66`	`66`
`67`		`- $folderName = basename($fileInfo->getPath());`
	`67`	`+ $folders = array_filter(explode('/', $fileInfo->getPath()));`
	`68`	`+ $folderName = array_pop($folders);`
`68`	`69`
`69`	`70`	`if ($folderName === 'data' \|\| $folderName === 'sql') {`
`70`	`71`	`$phpcsFile->addError(`