Merge pull request #37 from magento/REPO-70-Assign-severity-to-each-sniff

Assign severity to each sniff

Author: lenaorobei

Magento/Sniffs/Legacy/MageEntitySniff.php

@@ -13,11 +13,11 @@
  */
 class MageEntitySniff implements Sniff
 {
-   /**
-    * String representation of error.
-    *
-    * @var string
-    */
+    /**
+     * String representation of error.
+     *
+     * @var string
+     */
     protected $errorMessage = 'Possible Magento 2 design violation. Detected typical Magento 1.x construction "%s".';
 
     /**

Magento/Sniffs/Security/IncludeFileSniff.php

@@ -14,11 +14,11 @@
  */
 class IncludeFileSniff implements Sniff
 {
-   /**
-    * Warning violation code.
-    *
-    * @var string
-    */
+    /**
+     * Warning violation code.
+     *
+     * @var string
+     */
     protected $warningCode = 'FoundIncludeFile';
 
     /**
@@ -93,7 +93,7 @@ public function process(File $phpcsFile, $stackPtr)
         if ($hasVariable) {
             $message .= ' Variables inside are insecure.';
         }
-        $phpcsFile->addWarning(
+        $phpcsFile->addError(
             $message,
             $stackPtr,
             $this->warningCode,

Magento/Tests/Security/IncludeFileUnitTest.php

@@ -3,6 +3,7 @@
  * Copyright © Magento. All rights reserved.
  * See COPYING.txt for license details.
  */
+
 namespace Magento\Tests\Security;
 
 use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest;
@@ -16,14 +17,6 @@ class IncludeFileUnitTest extends AbstractSniffUnitTest
      * @inheritdoc
      */
     public function getErrorList()
-    {
-        return [];
-    }
-
-    /**
-     * @inheritdoc
-     */
-    public function getWarningList()
     {
         return [
             3 => 1,
@@ -42,4 +35,12 @@ public function getWarningList()
             34 => 1,
         ];
     }
+
+    /**
+     * @inheritdoc
+     */
+    public function getWarningList()
+    {
+        return [];
+    }
 }