AC-661: Create phpcs static check for XmlTest

Author: jcuerdo

Magento2/Sniffs/Legacy/WidgetXMLSniff.php

@@ -38,12 +38,8 @@ public function process(File $phpcsFile, $stackPtr)
             return;
         }
 
-        try {
-            $xml = simplexml_load_string($this->getFormattedXML($phpcsFile));
-        } catch (\Exception $e) {
-            $this->invalidXML($phpcsFile, $stackPtr);
-            return;
-        }
+        $xml = simplexml_load_string($this->getFormattedXML($phpcsFile));
+
         if ($xml === false) {
             $this->invalidXML($phpcsFile, $stackPtr);
             return;
@@ -102,20 +98,6 @@ protected function invalidXML(File $phpcsFile, int $stackPtr): void
         );
     }
 
-    /**
-     * Check if the element passed is in the currently sniffed line
-     *
-     * @param SimpleXMLElement $element
-     * @param int $stackPtr
-     * @return bool
-     */
-    private function elementIsCurrentlySniffedLine(SimpleXMLElement $element, int $stackPtr): bool
-    {
-        $node = dom_import_simplexml($element);
-
-        return $node->getLineNo() === $stackPtr + 1;
-    }
-
     /**
      * Format the incoming XML to avoid tags split into several lines.
      *

Magento2/Tests/Legacy/WidgetXMLUnitTest.2.xml

@@ -7,5 +7,27 @@
 -->
 <widgets>
     <widget
+            type="/Deprecated"
+    >
+        <label
+                translate="true"
+        >Catalog New Products List
+
+        </label>
+
+
+        <description translate="true">List of Products that are set as New</description>
+
+        <supported_blocks>
+
+
+            Deprecated
+
+
+            <block>
+                <block_name>Deprecated</block_name>
+            </block>
+        </supported_blocks>
+    </widget>
 </widgets>
 

Magento2/Tests/Legacy/WidgetXMLUnitTest.3.xml

@@ -0,0 +1,22 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+-->
+<widgets>
+    <widget
+    >
+        <label
+                translate="true"
+        />
+        <description
+                translate="true"
+        >
+            List of Products that are set as New
+        </description>
+
+    </widget>
+</widgets>
+

Magento2/Tests/Legacy/WidgetXMLUnitTest.php

@@ -23,7 +23,9 @@ public function getErrorList($testFile = '')
         }
         if ($testFile === 'WidgetXMLUnitTest.2.xml') {
             return [
-                1 => 1
+                9 => 1,
+                17 => 1,
+                24 => 1,
             ];
         }
         return [];