Skip to content

Commit 72bd288

Browse files
authored
Merge pull request #85 from magento-commerce/AC-205
AC-1159: Move eslint tests to magento-coding-standard
2 parents dc56f12 + 79b6b3d commit 72bd288

5 files changed

+4
-4
lines changed

.github/workflows/php.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ jobs:
4242
- name: Install dependencies
4343
run: npm install
4444
- name: Run ESLint
45-
run: npm run eslint -- eslint/rules
45+
run: npm run eslint -- eslint/rules Magento2/ --ignore-pattern 'Magento2/Tests/Eslint/*Test.js'
4646

4747
- name: Validate composer
4848
run: composer validate

Magento2/Tests/Eslint/ClickEventShorthandTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class ClickEventShorthandTest extends AbstractEslintTestCase
1717
public function testExecute(): void
1818
{
1919
$this->assertFileContainsError(
20-
'ClickEventShorthand.js',
20+
'ClickEventShorthandTest.js',
2121
['Instead of .blur(fn) use .on("blur", fn). Instead of .blur() use .trigger("blur")']
2222
);
2323
}

Magento2/Tests/Legacy/CopyrightAnotherExtensionsFilesUnitTest.2.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,5 @@
66
define([
77
'jquery'
88
], function (){
9-
9+
'use strict';
1010
});

Magento2/Tests/Legacy/CopyrightAnotherExtensionsFilesUnitTest.4.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,5 @@
66
define([
77
'jquery'
88
], function (){
9-
9+
'use strict';
1010
});

0 commit comments

Comments
 (0)