Merge pull request #125 from magento-commerce/imported-sivaschenko-magento-coding-standard-336

[Imported] Fixed AutogeneratedClassNotInConstructorSniff for specific code constructions

Author: sivaschenko

Magento2/Sniffs/PHP/AutogeneratedClassNotInConstructorSniff.php

@@ -47,10 +47,13 @@ public function process(File $phpcsFile, $stackPtr)
         }
 
         if (!isset($tokens[$stackPtr + 4]) || $tokens[$stackPtr + 4]['code'] !== T_SEMICOLON) {
-            $this->validateRequestedClass(
-                $phpcsFile,
-                $phpcsFile->findNext(T_OBJECT_OPERATOR, $stackPtr)
-            );
+            $arrowPosition = $phpcsFile->findNext(T_OBJECT_OPERATOR, $stackPtr);
+            if ($arrowPosition !== false) {
+                $this->validateRequestedClass(
+                    $phpcsFile,
+                    $arrowPosition
+                );
+            }
             return;
         }
 

Magento2/Tests/PHP/AutogeneratedClassNotInConstructorUnitTest.2.php.inc

@@ -36,5 +36,10 @@ class Bad
         ObjectManager::getInstance()
             ->get(\Full\Class\NameFactory::class);
     }
+
+    private function foo(): void
+    {
+        ObjectManager::getInstance() ;
+    }
 }