Skip to content

Commit 1d3fa20

Browse files
committed
AC-1059: Move PHPCompatibility rules from Magento tests
1 parent 1b2153f commit 1d3fa20

File tree

2 files changed

+16
-6
lines changed

2 files changed

+16
-6
lines changed

Magento2/ruleset.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -738,9 +738,3 @@
738738
<severity>0</severity>
739739
</rule>
740740
</ruleset>
741-
<ruleset name="PHPCompatibilityMagento">
742-
<description>Magento 2 specific ruleset which checks for PHP cross version compatibility.</description>
743-
<rule ref="PHPCompatibility">
744-
<exclude name="PHPCompatibility.Miscellaneous.RemovedAlternativePHPTags.MaybeASPOpenTagFound" />
745-
</rule>
746-
</ruleset>

PHPCompatibilityMagento/ruleset.xml

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
<?xml version="1.0"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
<ruleset name="PHPCompatibilityMagento">
9+
<description>Magento 2 specific ruleset which checks for PHP cross version compatibility.</description>
10+
<rule ref="../vendor/phpcompatibility/php-compatibility/PHPCompatibility">
11+
<exclude name="PHPCompatibility.Miscellaneous.RemovedAlternativePHPTags.MaybeASPOpenTagFound" />
12+
<exclude name="PHPCompatibility.FunctionUse.RequiredToOptionalFunctionParameters" />
13+
<exclude name="PHPCompatibility.ParameterValues.RemovedPCREModifiers" />
14+
<exclude name="PHPCompatibility.InitialValue.NewConstantScalarExpressions" />
15+
</rule>
16+
</ruleset>

0 commit comments

Comments
 (0)