Skip to content

[Bug]: <Hidden Module is disabled in preview/view modes> #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
jnewman-eti opened this issue Aug 8, 2023 · 1 comment
Closed
1 task done

[Bug]: <Hidden Module is disabled in preview/view modes> #336

jnewman-eti opened this issue Aug 8, 2023 · 1 comment
Assignees
Labels
Bug Something isn't working Components Dedicated to Frontend Visual Components

Comments

@jnewman-eti
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

I created a module to handle some common tasks across my applications, that will perform some queries and provide some output data for apps to use. There are no UI components in this module, and it is intended to be hidden from the UI inside the apps. When this module is hidden, in edit mode everything works as expected. The module performs its work, executes a success event, and triggers the apps to begin performing subsequent work.
However, in preview/view modes, the module does not perform the intended work, and the success event never fires, preventing the apps from beginning performing their work.

Due to the discrepancy between edit and view modes in this instance, it seems this behavior is not intentional. A hidden component is not necessarily intended to be disabled, as per my understanding.

If this is intentional, how could a developer group a batch of queries/transformers/temporary state objects together that are intended to perform a specific task together, to be able to reuse this in multiple apps?

Expected Behavior

If a module is used inside an app, and it is hidden, it should not be disabled.

Steps to reproduce

  1. Create a new module.
  2. Create some query that the module can execute on page load.
  3. Create an event to fire upon completion of the query run (not an event handler, but a module event.)
  4. Add a success event handler on the query created, and on success, trigger the module event.
  5. Publish the module, and add it to an app.
  6. On the app module properties, in the "hidden" property, set it to "true". The module will hide. In edit mode, the module should trigger the event successfully.
  7. Switch to preview/view mode. The module will not execute and will not trigger the event successfully.

Environment

Using a synced fork of the main branch. Currently 10 commits ahead of main branch.

Additional Information

No response

@jnewman-eti jnewman-eti added Bug Something isn't working Needs triage Needs to be reviewed by core team labels Aug 8, 2023
@FalkWolsky FalkWolsky added Components Dedicated to Frontend Visual Components and removed Needs triage Needs to be reviewed by core team labels Aug 20, 2023
@FalkWolsky
Copy link
Contributor

We solved this in v2.1.7. Can you please re-check it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Components Dedicated to Frontend Visual Components
Projects
None yet
Development

No branches or pull requests

3 participants