Skip to content

Commit 15f9a42

Browse files
committed
Factorize some more code
Signed-off-by: Francis Galiegue <[email protected]>
1 parent da6a834 commit 15f9a42

File tree

5 files changed

+8
-123
lines changed

5 files changed

+8
-123
lines changed

src/main/java/com/github/fge/jsonschema/processors/walk/DraftV4PointerCollectorDictionary.java

+4-6
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,8 @@
1919

2020
import com.github.fge.jsonschema.library.Dictionary;
2121
import com.github.fge.jsonschema.library.DictionaryBuilder;
22-
import com.github.fge.jsonschema.processors.walk.draftv4.AllOfPointerCollector;
23-
import com.github.fge.jsonschema.processors.walk.draftv4.AnyOfPointerCollector;
2422
import com.github.fge.jsonschema.processors.walk.draftv4.NotPointerCollector;
25-
import com.github.fge.jsonschema.processors.walk.draftv4.OneOfPointerCollector;
23+
import com.github.fge.jsonschema.processors.walk.helpers.SchemaArrayPointerCollector;
2624
import com.github.fge.jsonschema.processors.walk.helpers.SchemaMapPointerCollector;
2725

2826
public final class DraftV4PointerCollectorDictionary
@@ -43,11 +41,11 @@ private DraftV4PointerCollectorDictionary()
4341
PointerCollector collector;
4442

4543
keyword = "allOf";
46-
collector = AllOfPointerCollector.getInstance();
44+
collector = new SchemaArrayPointerCollector(keyword);
4745
builder.addEntry(keyword, collector);
4846

4947
keyword = "anyOf";
50-
collector = AnyOfPointerCollector.getInstance();
48+
collector = new SchemaArrayPointerCollector(keyword);
5149
builder.addEntry(keyword, collector);
5250

5351
keyword = "definitions";
@@ -59,7 +57,7 @@ private DraftV4PointerCollectorDictionary()
5957
builder.addEntry(keyword, collector);
6058

6159
keyword = "oneOf";
62-
collector = OneOfPointerCollector.getInstance();
60+
collector = new SchemaArrayPointerCollector(keyword);
6361
builder.addEntry(keyword, collector);
6462

6563
DICTIONARY = builder.freeze();

src/main/java/com/github/fge/jsonschema/processors/walk/draftv4/AllOfPointerCollector.java

-38
This file was deleted.

src/main/java/com/github/fge/jsonschema/processors/walk/draftv4/AnyOfPointerCollector.java

-38
This file was deleted.

src/main/java/com/github/fge/jsonschema/processors/walk/draftv4/OneOfPointerCollector.java

-38
This file was deleted.

src/main/java/com/github/fge/jsonschema/processors/walk/helpers/SchemaArrayPointerCollector.java

+4-3
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,16 @@
2222

2323
import java.util.Collection;
2424

25-
public abstract class SchemaArrayPointerCollector
25+
public final class SchemaArrayPointerCollector
2626
extends AbstractPointerCollector
2727
{
28-
protected SchemaArrayPointerCollector(final String keyword) {
28+
public SchemaArrayPointerCollector(final String keyword)
29+
{
2930
super(keyword);
3031
}
3132

3233
@Override
33-
public final void collect(final Collection<JsonPointer> pointers,
34+
public void collect(final Collection<JsonPointer> pointers,
3435
final SchemaTree tree)
3536
{
3637
final int size = getNode(tree).size();

0 commit comments

Comments
 (0)