From e6d88a74f0c832c7bfdd984e0f18a5462b4de12e Mon Sep 17 00:00:00 2001
From: Arno <arnotixe@gmail.com>
Date: Wed, 20 Jul 2022 10:14:56 -0500
Subject: [PATCH 1/3] WIP: add some documentation on IonicSlides

WIP: would be great to have  some documentation on IonicSlides actually do. Migrating from ion-slides I got the regression that pinch zoom on mobiles work, but doubleclick to zoom (desktop) stopped working. Puzzled because https://swiperjs.com/types/interfaces/types_modules_zoom.zoomoptions says toggle is default true - and then I came to think about IonicSlides.

Not sure this is the best place to put it though, but it would be convenient with a list of what settings IonicSlides overrides somewhere, and link to it.
---
 docs/angular/slides.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/angular/slides.md b/docs/angular/slides.md
index afeda06f317..1d64e77cec2 100644
--- a/docs/angular/slides.md
+++ b/docs/angular/slides.md
@@ -166,7 +166,7 @@ See <a href="https://swiperjs.com/angular#usage" target="_blank" rel="noopener n
 
 ## The IonicSlides Module
 
-With `ion-slides`, Ionic automatically customized dozens of Swiper properties. This resulted in an experience that felt smooth when swiping on mobile devices. We recommend using the `IonicSlides` module to ensure that these properties are also set when using Swiper directly.
+With `ion-slides`, Ionic automatically customized dozens of Swiper properties, for example turning off zoom on doubleclick. This resulted in an experience that felt smooth when swiping on mobile devices. We recommend using the `IonicSlides` module to ensure that these properties are also set when using Swiper directly.
 
 We can install the `IonicSlides` module by importing it from `@ionic/angular` and passing it in as the last item in the array provided in `SwiperCore.use`:
 

From 39a3d0e7b6d3a394fa8f6006600175d0c77e59ed Mon Sep 17 00:00:00 2001
From: Maria Hutt <maria@ionic.io>
Date: Tue, 25 Apr 2023 11:02:52 -0700
Subject: [PATCH 2/3] docs(ionicslides): properties link recommendation

---
 docs/angular/slides.md                      | 2 ++
 docs/react/slides.md                        | 2 ++
 docs/vue/slides.md                          | 2 ++
 versioned_docs/version-v6/angular/slides.md | 2 ++
 versioned_docs/version-v6/react/slides.md   | 2 ++
 versioned_docs/version-v6/vue/slides.md     | 2 ++
 6 files changed, 12 insertions(+)

diff --git a/docs/angular/slides.md b/docs/angular/slides.md
index 104bd4097ed..491eba59a9a 100644
--- a/docs/angular/slides.md
+++ b/docs/angular/slides.md
@@ -135,6 +135,8 @@ swiper-slide img {
 
 With `ion-slides`, Ionic automatically customized dozens of Swiper properties. This resulted in an experience that felt smooth when swiping on mobile devices. We recommend using the `IonicSlides` module to ensure that these properties are also set when using Swiper directly. However, using this module is **not** required to use Swiper.js in Ionic.
 
+It is recommended to review the [properties](https://github.com/ionic-team/ionic-framework/blob/9f51bdc14556aed0047627f147defc3d0043046c/core/src/components/slides/IonicSlides.ts#L3) set by `IonicSlides` and determine which ones you would like to customize.
+
 We can install the `IonicSlides` module by importing it from `@ionic/angular` and passing it to the `modules` property of `swiper-container` as an array:
 
 ```typescript
diff --git a/docs/react/slides.md b/docs/react/slides.md
index b8d88392314..6c09a00d3b1 100644
--- a/docs/react/slides.md
+++ b/docs/react/slides.md
@@ -264,6 +264,8 @@ See <a href="https://swiperjs.com/react#usage" target="_blank" rel="noopener nor
 
 With `IonSlides`, Ionic automatically customized dozens of Swiper properties. This resulted in an experience that felt smooth when swiping on mobile devices. We recommend using the `IonicSlides` module to ensure that these properties are also set when using Swiper directly. However, using this module is **not** required to use Swiper.js in Ionic.
 
+It is recommended to review the [properties](https://github.com/ionic-team/ionic-framework/blob/9f51bdc14556aed0047627f147defc3d0043046c/core/src/components/slides/IonicSlides.ts#L3) set by `IonicSlides` and determine which ones you would like to customize.
+
 We can install the `IonicSlides` module by importing it from `@ionic/react` and passing it in as the last item in the `modules` array:
 
 ```tsx
diff --git a/docs/vue/slides.md b/docs/vue/slides.md
index 4f02bd9813c..4e7821d8c70 100644
--- a/docs/vue/slides.md
+++ b/docs/vue/slides.md
@@ -256,6 +256,8 @@ See <a href="https://swiperjs.com/vue#usage" target="_blank" rel="noopener noref
 
 With `ion-slides`, Ionic automatically customized dozens of Swiper properties. This resulted in an experience that felt smooth when swiping on mobile devices. We recommend using the `IonicSlides` module to ensure that these properties are also set when using Swiper directly. However, using this module is **not** required to use Swiper.js in Ionic.
 
+It is recommended to review the [properties](https://github.com/ionic-team/ionic-framework/blob/9f51bdc14556aed0047627f147defc3d0043046c/core/src/components/slides/IonicSlides.ts#L3) set by `IonicSlides` and determine which ones you would like to customize.
+
 We can install the `IonicSlides` module by importing it from `@ionic/vue` and passing it in as the last item in the `modules` array:
 
 ```html
diff --git a/versioned_docs/version-v6/angular/slides.md b/versioned_docs/version-v6/angular/slides.md
index 7e5870e8cfa..cedf1b12b45 100644
--- a/versioned_docs/version-v6/angular/slides.md
+++ b/versioned_docs/version-v6/angular/slides.md
@@ -133,6 +133,8 @@ swiper-slide img {
 
 With `ion-slides`, Ionic automatically customized dozens of Swiper properties. This resulted in an experience that felt smooth when swiping on mobile devices. We recommend using the `IonicSlides` module to ensure that these properties are also set when using Swiper directly. However, using this module is **not** required to use Swiper.js in Ionic.
 
+It is recommended to review the [properties](https://github.com/ionic-team/ionic-framework/blob/9f51bdc14556aed0047627f147defc3d0043046c/core/src/components/slides/IonicSlides.ts#L3) set by `IonicSlides` and determine which ones you would like to customize.
+
 We can install the `IonicSlides` module by importing it from `@ionic/angular` and passing it to the `modules` property of `swiper-container` as an array:
 
 ```typescript
diff --git a/versioned_docs/version-v6/react/slides.md b/versioned_docs/version-v6/react/slides.md
index b6cb227f408..fff2dafb48a 100644
--- a/versioned_docs/version-v6/react/slides.md
+++ b/versioned_docs/version-v6/react/slides.md
@@ -260,6 +260,8 @@ See <a href="https://swiperjs.com/react#usage" target="_blank" rel="noopener nor
 
 With `IonSlides`, Ionic automatically customized dozens of Swiper properties. This resulted in an experience that felt smooth when swiping on mobile devices. We recommend using the `IonicSlides` module to ensure that these properties are also set when using Swiper directly. However, using this module is **not** required to use Swiper.js in Ionic.
 
+It is recommended to review the [properties](https://github.com/ionic-team/ionic-framework/blob/9f51bdc14556aed0047627f147defc3d0043046c/core/src/components/slides/IonicSlides.ts#L3) set by `IonicSlides` and determine which ones you would like to customize.
+
 We can install the `IonicSlides` module by importing it from `@ionic/react` and passing it in as the last item in the `modules` array:
 
 ```tsx
diff --git a/versioned_docs/version-v6/vue/slides.md b/versioned_docs/version-v6/vue/slides.md
index 7f63df400be..cba9c186439 100644
--- a/versioned_docs/version-v6/vue/slides.md
+++ b/versioned_docs/version-v6/vue/slides.md
@@ -254,6 +254,8 @@ See <a href="https://swiperjs.com/vue#usage" target="_blank" rel="noopener noref
 
 With `ion-slides`, Ionic automatically customized dozens of Swiper properties. This resulted in an experience that felt smooth when swiping on mobile devices. We recommend using the `IonicSlides` module to ensure that these properties are also set when using Swiper directly. However, using this module is **not** required to use Swiper.js in Ionic.
 
+It is recommended to review the [properties](https://github.com/ionic-team/ionic-framework/blob/9f51bdc14556aed0047627f147defc3d0043046c/core/src/components/slides/IonicSlides.ts#L3) set by `IonicSlides` and determine which ones you would like to customize.
+
 We can install the `IonicSlides` module by importing it from `@ionic/vue` and passing it in as the last item in the `modules` array:
 
 ```html

From 2e5ae1eb23057a0e4feee28587e317ca0830e608 Mon Sep 17 00:00:00 2001
From: Maria Hutt <maria@ionic.io>
Date: Tue, 25 Apr 2023 11:28:57 -0700
Subject: [PATCH 3/3] docs(ionicslides): update to permalink

---
 docs/angular/slides.md                      | 2 +-
 docs/react/slides.md                        | 2 +-
 docs/vue/slides.md                          | 2 +-
 versioned_docs/version-v6/angular/slides.md | 2 +-
 versioned_docs/version-v6/react/slides.md   | 2 +-
 versioned_docs/version-v6/vue/slides.md     | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/docs/angular/slides.md b/docs/angular/slides.md
index 491eba59a9a..f294bcc351c 100644
--- a/docs/angular/slides.md
+++ b/docs/angular/slides.md
@@ -135,7 +135,7 @@ swiper-slide img {
 
 With `ion-slides`, Ionic automatically customized dozens of Swiper properties. This resulted in an experience that felt smooth when swiping on mobile devices. We recommend using the `IonicSlides` module to ensure that these properties are also set when using Swiper directly. However, using this module is **not** required to use Swiper.js in Ionic.
 
-It is recommended to review the [properties](https://github.com/ionic-team/ionic-framework/blob/9f51bdc14556aed0047627f147defc3d0043046c/core/src/components/slides/IonicSlides.ts#L3) set by `IonicSlides` and determine which ones you would like to customize.
+It is recommended to review the [properties](https://github.com/ionic-team/ionic-framework/blob/main/core/src/components/slides/IonicSlides.ts) set by `IonicSlides` and determine which ones you would like to customize.
 
 We can install the `IonicSlides` module by importing it from `@ionic/angular` and passing it to the `modules` property of `swiper-container` as an array:
 
diff --git a/docs/react/slides.md b/docs/react/slides.md
index 6c09a00d3b1..522bc2d36ac 100644
--- a/docs/react/slides.md
+++ b/docs/react/slides.md
@@ -264,7 +264,7 @@ See <a href="https://swiperjs.com/react#usage" target="_blank" rel="noopener nor
 
 With `IonSlides`, Ionic automatically customized dozens of Swiper properties. This resulted in an experience that felt smooth when swiping on mobile devices. We recommend using the `IonicSlides` module to ensure that these properties are also set when using Swiper directly. However, using this module is **not** required to use Swiper.js in Ionic.
 
-It is recommended to review the [properties](https://github.com/ionic-team/ionic-framework/blob/9f51bdc14556aed0047627f147defc3d0043046c/core/src/components/slides/IonicSlides.ts#L3) set by `IonicSlides` and determine which ones you would like to customize.
+It is recommended to review the [properties](https://github.com/ionic-team/ionic-framework/blob/main/core/src/components/slides/IonicSlides.ts) set by `IonicSlides` and determine which ones you would like to customize.
 
 We can install the `IonicSlides` module by importing it from `@ionic/react` and passing it in as the last item in the `modules` array:
 
diff --git a/docs/vue/slides.md b/docs/vue/slides.md
index 4e7821d8c70..854c845d6d0 100644
--- a/docs/vue/slides.md
+++ b/docs/vue/slides.md
@@ -256,7 +256,7 @@ See <a href="https://swiperjs.com/vue#usage" target="_blank" rel="noopener noref
 
 With `ion-slides`, Ionic automatically customized dozens of Swiper properties. This resulted in an experience that felt smooth when swiping on mobile devices. We recommend using the `IonicSlides` module to ensure that these properties are also set when using Swiper directly. However, using this module is **not** required to use Swiper.js in Ionic.
 
-It is recommended to review the [properties](https://github.com/ionic-team/ionic-framework/blob/9f51bdc14556aed0047627f147defc3d0043046c/core/src/components/slides/IonicSlides.ts#L3) set by `IonicSlides` and determine which ones you would like to customize.
+It is recommended to review the [properties](https://github.com/ionic-team/ionic-framework/blob/main/core/src/components/slides/IonicSlides.ts) set by `IonicSlides` and determine which ones you would like to customize.
 
 We can install the `IonicSlides` module by importing it from `@ionic/vue` and passing it in as the last item in the `modules` array:
 
diff --git a/versioned_docs/version-v6/angular/slides.md b/versioned_docs/version-v6/angular/slides.md
index cedf1b12b45..e971d03c557 100644
--- a/versioned_docs/version-v6/angular/slides.md
+++ b/versioned_docs/version-v6/angular/slides.md
@@ -133,7 +133,7 @@ swiper-slide img {
 
 With `ion-slides`, Ionic automatically customized dozens of Swiper properties. This resulted in an experience that felt smooth when swiping on mobile devices. We recommend using the `IonicSlides` module to ensure that these properties are also set when using Swiper directly. However, using this module is **not** required to use Swiper.js in Ionic.
 
-It is recommended to review the [properties](https://github.com/ionic-team/ionic-framework/blob/9f51bdc14556aed0047627f147defc3d0043046c/core/src/components/slides/IonicSlides.ts#L3) set by `IonicSlides` and determine which ones you would like to customize.
+It is recommended to review the [properties](https://github.com/ionic-team/ionic-framework/blob/main/core/src/components/slides/IonicSlides.ts) set by `IonicSlides` and determine which ones you would like to customize.
 
 We can install the `IonicSlides` module by importing it from `@ionic/angular` and passing it to the `modules` property of `swiper-container` as an array:
 
diff --git a/versioned_docs/version-v6/react/slides.md b/versioned_docs/version-v6/react/slides.md
index fff2dafb48a..c6e3d0ea382 100644
--- a/versioned_docs/version-v6/react/slides.md
+++ b/versioned_docs/version-v6/react/slides.md
@@ -260,7 +260,7 @@ See <a href="https://swiperjs.com/react#usage" target="_blank" rel="noopener nor
 
 With `IonSlides`, Ionic automatically customized dozens of Swiper properties. This resulted in an experience that felt smooth when swiping on mobile devices. We recommend using the `IonicSlides` module to ensure that these properties are also set when using Swiper directly. However, using this module is **not** required to use Swiper.js in Ionic.
 
-It is recommended to review the [properties](https://github.com/ionic-team/ionic-framework/blob/9f51bdc14556aed0047627f147defc3d0043046c/core/src/components/slides/IonicSlides.ts#L3) set by `IonicSlides` and determine which ones you would like to customize.
+It is recommended to review the [properties](https://github.com/ionic-team/ionic-framework/blob/main/core/src/components/slides/IonicSlides.ts) set by `IonicSlides` and determine which ones you would like to customize.
 
 We can install the `IonicSlides` module by importing it from `@ionic/react` and passing it in as the last item in the `modules` array:
 
diff --git a/versioned_docs/version-v6/vue/slides.md b/versioned_docs/version-v6/vue/slides.md
index cba9c186439..e28f84deba5 100644
--- a/versioned_docs/version-v6/vue/slides.md
+++ b/versioned_docs/version-v6/vue/slides.md
@@ -254,7 +254,7 @@ See <a href="https://swiperjs.com/vue#usage" target="_blank" rel="noopener noref
 
 With `ion-slides`, Ionic automatically customized dozens of Swiper properties. This resulted in an experience that felt smooth when swiping on mobile devices. We recommend using the `IonicSlides` module to ensure that these properties are also set when using Swiper directly. However, using this module is **not** required to use Swiper.js in Ionic.
 
-It is recommended to review the [properties](https://github.com/ionic-team/ionic-framework/blob/9f51bdc14556aed0047627f147defc3d0043046c/core/src/components/slides/IonicSlides.ts#L3) set by `IonicSlides` and determine which ones you would like to customize.
+It is recommended to review the [properties](https://github.com/ionic-team/ionic-framework/blob/main/core/src/components/slides/IonicSlides.ts) set by `IonicSlides` and determine which ones you would like to customize.
 
 We can install the `IonicSlides` module by importing it from `@ionic/vue` and passing it in as the last item in the `modules` array: