From 14619f38fca61f945d1b7aaae8cbd4e6727948b7 Mon Sep 17 00:00:00 2001 From: Brett Peary Date: Wed, 18 Jan 2023 09:38:09 +0900 Subject: [PATCH] Update pwa.md to reflect firebase-tools changes The steps required after performing `firebase init` have changed. These updates make it easy to follow and deploy your project. --- docs/react/pwa.md | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/docs/react/pwa.md b/docs/react/pwa.md index 24611d1c5ad..a2ea7b4bc03 100644 --- a/docs/react/pwa.md +++ b/docs/react/pwa.md @@ -64,18 +64,36 @@ npm install -g firebase-tools With the Firebase CLI installed, run `firebase init` within your Ionic project. The CLI prompts: -**"Which Firebase CLI features do you want to set up for this folder?"** Choose "Hosting: Configure and deploy Firebase Hosting sites." +**"Which Firebase CLI features do you want to set up for this folder?"** Choose "Hosting: Configure files for Firebase Hosting and (optionally) set up GitHub Action deploys" and press spacebar & then enter + +Create a new Firebase project or select an existing one. **"Select a default Firebase project for this directory:"** Choose the project you created on the Firebase website. **"What do you want to use as your public directory?"** Enter "build". :::note -Answering these next two questions will ensure that routing, hard reload, and deep linking work in the app: +Answering this next question will ensure that routing, hard reload, and deep linking work in the app: ::: **Configure as a single-page app (rewrite all urls to /index.html)?"** Enter "Yes". +**Set up automatic builds and deploys with github?** Enter "Yes". + +**For which GitHub repository would you like to set up a Github Workflow?** Enter your project name. + +**Set up the workflow to run a build script before every deploy?** Enter "Yes". + +**What script should be run before every deploy? (npm ci && npm run build)** Enter `npm ci && npm run build`. + +**Set up automatic deployment to your sites live channel when a PR is merged?** Enter "Yes". + +**What is the name of the get hooked branch associated with your sites live channel?** Enter your project's main brainch name. + +:::note +Answering this next question also will ensure that routing, hard reload, and deep linking work in the app: +::: + **"File build/index.html already exists. Overwrite?"** Enter "No". A `firebase.json` config file is generated, configuring the app for deployment.