Skip to content

Commit af6249f

Browse files
fix(nav-link): opt-out of vue reactivity for component binding (#3113)
Co-authored-by: David Kagiri <[email protected]>
1 parent bb90741 commit af6249f

File tree

6 files changed

+12
-6
lines changed

6 files changed

+12
-6
lines changed

static/usage/v6/nav/nav-link/vue/example_vue.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,15 @@
44
</template>
55

66
<script lang="ts">
7+
import { markRaw } from 'vue';
78
import { IonNav } from '@ionic/vue';
89
import PageOne from './PageOne.vue';
910
1011
export default {
1112
components: { IonNav },
1213
data() {
1314
return {
14-
component: PageOne,
15+
component: markRaw(PageOne),
1516
};
1617
},
1718
};

static/usage/v6/nav/nav-link/vue/page_one_vue.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,15 @@
1414
</template>
1515

1616
<script lang="ts">
17+
import { markRaw } from 'vue';
1718
import { IonHeader, IonTitle, IonToolbar, IonContent, IonNavLink, IonButton } from '@ionic/vue';
1819
import PageTwo from './PageTwo.vue';
1920
2021
export default {
2122
components: { IonHeader, IonTitle, IonToolbar, IonContent, IonNavLink, IonButton },
2223
data() {
2324
return {
24-
component: PageTwo,
25+
component: markRaw(PageTwo),
2526
};
2627
},
2728
};

static/usage/v6/nav/nav-link/vue/page_two_vue.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
</template>
1818

1919
<script lang="ts">
20+
import { markRaw } from 'vue';
2021
import {
2122
IonHeader,
2223
IonTitle,
@@ -42,7 +43,7 @@
4243
},
4344
data() {
4445
return {
45-
component: PageThree,
46+
component: markRaw(PageThree),
4647
};
4748
},
4849
};

static/usage/v7/nav/nav-link/vue/example_vue.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,15 @@
44
</template>
55

66
<script lang="ts">
7+
import { markRaw } from 'vue';
78
import { IonNav } from '@ionic/vue';
89
import PageOne from './PageOne.vue';
910
1011
export default {
1112
components: { IonNav },
1213
data() {
1314
return {
14-
component: PageOne,
15+
component: markRaw(PageOne),
1516
};
1617
},
1718
};

static/usage/v7/nav/nav-link/vue/page_one_vue.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,15 @@
1414
</template>
1515

1616
<script lang="ts">
17+
import { markRaw } from 'vue';
1718
import { IonHeader, IonTitle, IonToolbar, IonContent, IonNavLink, IonButton } from '@ionic/vue';
1819
import PageTwo from './PageTwo.vue';
1920
2021
export default {
2122
components: { IonHeader, IonTitle, IonToolbar, IonContent, IonNavLink, IonButton },
2223
data() {
2324
return {
24-
component: PageTwo,
25+
component: markRaw(PageTwo),
2526
};
2627
},
2728
};

static/usage/v7/nav/nav-link/vue/page_two_vue.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
</template>
1818

1919
<script lang="ts">
20+
import { markRaw } from 'vue';
2021
import {
2122
IonHeader,
2223
IonTitle,
@@ -42,7 +43,7 @@
4243
},
4344
data() {
4445
return {
45-
component: PageThree,
46+
component: markRaw(PageThree),
4647
};
4748
},
4849
};

0 commit comments

Comments
 (0)